<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> </head> <body> <div dir="auto">Hi Jouni</div> <div dir="auto"><br> </div> <div dir="auto">Okay. Seems reasonable. Reviewed-by is already there for the patches.</div> <div dir="auto"><br> </div> <div dir="auto">Br</div> <div dir="auto">Vinod</div> <div id="mail-editor-reference-message-container" dir="auto"><br> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" style="font-size: 11pt;"><strong>From:</strong> Hogander, Jouni <jouni.hogander@intel.com><br> <strong>Sent:</strong> Tuesday, September 19, 2023 8:39:24 am<br> <strong>To:</strong> intel-xe@lists.freedesktop.org <intel-xe@lists.freedesktop.org>; Govindapillai, Vinod <vinod.govindapillai@intel.com><br> <strong>Subject:</strong> Re: [Intel-xe] [PATCH 1/6] Revert "FIXME: drm/i915: include intel_frontbuffer.h from skl_universal_plane.c"<br> </div> <br> <meta name="Generator" content="Microsoft Exchange Server"> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Mon, 2023-09-18 at 20:54 +0000, Govindapillai, Vinod wrote:<br> > On Fri, 2023-09-15 at 13:57 +0300, Jouni Högander wrote:<br> > > This reverts commit c3e942a06433e8c538108f24b4fe78a0927e2aea.<br> > > <br> > > We are about to backport upstream changes that is taking care of<br> > > including<br> > > intel_frontbuffer.h as necessary.<br> > > <br> > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com><br> > > ---<br> > <br> > Hi Jouni,<br> > <br> > Should these reverts be moved after the patch 4 in this series? Won't<br> > that cause build failure? Or<br> > the patch description is not accurate?<br> <br> I choose this approach as backporting patch 4 would have lots of<br> conflicts if backporting it first. On next rebase all these patches<br> will disappear anyways.<br> <br> BR,<br> <br> Jouni Högander<br> <br> > <br> > With that checked, <br> > <br> > Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com><br> > <br> > > drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 -<br> > > 1 file changed, 1 deletion(-)<br> > > <br> > > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c<br> > > b/drivers/gpu/drm/i915/display/skl_universal_plane.c<br> > > index 4d01c7ae4485..2ded1bcce754 100644<br> > > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c<br> > > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c<br> > > @@ -16,7 +16,6 @@<br> > > #include "intel_display_types.h"<br> > > #include "intel_fb.h"<br> > > #include "intel_fbc.h"<br> > > -#include "intel_frontbuffer.h"<br> > > #include "intel_psr.h"<br> > > #include "skl_scaler.h"<br> > > #include "skl_universal_plane.h"<br> > <br> <br> </div> </span></font><br> </div> </body> </html>