<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 10-04-2024 00:22, Rodrigo Vivi wrote: </div> <blockquote type="cite" cite="mid:ZhWOV9puU8o3-qZM@intel.com"> <pre class="moz-quote-pre" wrap="">On Tue, Apr 09, 2024 at 12:52:34PM -0500, Lucas De Marchi wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On Fri, Apr 05, 2024 at 06:31:26PM +0530, Karthik Poosa wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Return u64 from xe_hwmon_process_reg, instead of a void return. u64* input pointer not needed with this change. With this caller can directly assign return value to a variable without need of explicit initialization and pass by reference. v2: - Fix checkpatch warnings. v3: - Rebase - Removed unncessary break statements. Signed-off-by: Karthik Poosa <a class="moz-txt-link-rfc2396E" href="mailto:karthik.poosa@intel.com"><karthik.poosa@intel.com></a> Suggested-by: Lucas De Marchi <a class="moz-txt-link-rfc2396E" href="mailto:lucas.demarchi@intel.com"><lucas.demarchi@intel.com></a> Cc: Badal Nilawar <a class="moz-txt-link-rfc2396E" href="mailto:badal.nilawar@intel.com"><badal.nilawar@intel.com></a> </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Applied the other patches. This one I'm putting on hold to think about. I'm not sure the approach in that hwmon in general is good with the xe_hwmon_get_reg() + xe_hwmon_process_reg(). It seems it's even taking some pm refs when it doesn't need (to decide if attribute is visible). </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I believe this approach is fine. We do need to earlier get pm refs if we believe that there will be mmio operations underneath. Better more then less in this case.</pre> </blockquote> <pre class="moz-quote-pre" wrap=""></pre> Rodrigo, We are already taking pm refs in parent calls of xe_hwmon_get/process_reg. Anything else needed here ? <blockquote type="cite" cite="mid:ZhWOV9puU8o3-qZM@intel.com"> <pre class="moz-quote-pre" wrap=""> </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> Lucas De Marchi </pre> </blockquote> </blockquote> </body> </html>