<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 4/15/2024 12:37, Jiapeng Chong
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20240415070722.5131-1-jiapeng.chong@linux.alibaba.com">
<pre class="moz-quote-pre" wrap="">No functional modification involved.
./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.</pre>
</blockquote>
<p>What i meant in the first review, was the commit description. The
commit subject looks better now, but the issue remains the same:
Line numbers will change after new code is added, so, it's better
to just write it as<br>
"Remove unnecessary semicolon in pick_engine_gt()" instead of "<span style="white-space: pre-wrap">./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon."</span></p>
<p><span style="white-space: pre-wrap">With that,
Reviewed-by: Shekhar Chauhan <a class="moz-txt-link-rfc2396E" href="mailto:shekhar.chauhan@intel.com"><shekhar.chauhan@intel.com></a>
</span></p>
<blockquote type="cite" cite="mid:20240415070722.5131-1-jiapeng.chong@linux.alibaba.com">
<pre class="moz-quote-pre" wrap="">
Reported-by: Abaci Robot <a class="moz-txt-link-rfc2396E" href="mailto:abaci@linux.alibaba.com"><abaci@linux.alibaba.com></a>
Closes: <a class="moz-txt-link-freetext" href="https://bugzilla.openanolis.cn/show_bug.cgi?id=8757">https://bugzilla.openanolis.cn/show_bug.cgi?id=8757</a>
Signed-off-by: Jiapeng Chong <a class="moz-txt-link-rfc2396E" href="mailto:jiapeng.chong@linux.alibaba.com"><jiapeng.chong@linux.alibaba.com></a>
---
Changes in v2:
-Make the commit message more clearer.
drivers/gpu/drm/xe/xe_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 996806353171..5b1a2f46a1b2 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
return tile->media_gt;
default:
break;
- };
+ }
fallthrough;
default:
return tile->primary_gt;
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
-shekhar</pre>
</body>
</html>