<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 23-04-2024 22:46, Matthew Brost wrote: </div> <blockquote type="cite" cite="mid:Zifs%2FD2+T9qwZNEj@DUT025-TGLU.fm.intel.com"> <pre class="moz-quote-pre" wrap="">On Tue, Apr 23, 2024 at 08:21:34AM -0700, Dixit, Ashutosh wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On Tue, 23 Apr 2024 00:03:32 -0700, Himal Prasad Ghimiray wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Hi Himal, </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">There is no change in functionality. Using the helper function defined within the driver. Cc: Matthew Brost <a class="moz-txt-link-rfc2396E" href="mailto:matthew.brost@intel.com"><matthew.brost@intel.com></a> Signed-off-by: Himal Prasad Ghimiray <a class="moz-txt-link-rfc2396E" href="mailto:himal.prasad.ghimiray@intel.com"><himal.prasad.ghimiray@intel.com></a> --- drivers/gpu/drm/xe/xe_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index 85d6f359142d..e9c8dc6d7b83 100644 --- a/drivers/gpu/drm/xe/xe_vm.c +++ b/drivers/gpu/drm/xe/xe_vm.c @@ -1279,7 +1279,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags) drm_gem_object_put(vm_resv_obj); - err = dma_resv_lock_interruptible(xe_vm_resv(vm), NULL); + err = xe_vm_lock(vm, true); if (err) goto err_close; </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> But isn't dma_resv_lock coupled with dma_resv_unlock? So that should also be changed, if at all? And what about other places in Xe which still </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Yes, this function should be updated with s/dma_resv_unlock/xe_vm_unlock now.</pre> </blockquote> <span style="color: rgb(13, 13, 13); font-family: Söhne, ui-sans-serif, system-ui, -apple-system, "Segoe UI", Roboto, Ubuntu, Cantarell, "Noto Sans", sans-serif, "Helvetica Neue", Arial, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre-wrap; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">Thank you, Ashutosh/Matt, for bringing this to my attention. It was an oversight on my part, and I will update it in the next version <span style="color: rgb(13, 13, 13); font-family: Söhne, ui-sans-serif, system-ui, -apple-system, "Segoe UI", Roboto, Ubuntu, Cantarell, "Noto Sans", sans-serif, "Helvetica Neue", Arial, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre-wrap; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"> <blockquote type="cite" cite="mid:Zifs%2FD2+T9qwZNEj@DUT025-TGLU.fm.intel.com"> <pre class="moz-quote-pre" wrap=""> </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">contain dma_resv_lock_interruptible? </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I found two places that also could be updated to use the locking wrappers: xe_lrc_snapshot_capture_delayed should be updated with xe_bo_lock xe_vm_snapshot_capture_delayed should be updated with xe_bo_lock</pre> </blockquote> Will upload a patch to take care of this. Thanks. <blockquote type="cite" cite="mid:Zifs%2FD2+T9qwZNEj@DUT025-TGLU.fm.intel.com"> <pre class="moz-quote-pre" wrap=""> Matt </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Ashutosh </pre> </blockquote> </blockquote> </body> </html>