<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 24-04-2024 17:55, Rodrigo Vivi wrote: </div> <blockquote type="cite" cite="mid:Zij6Qh1rvGTOG3e6@intel.com"> <pre class="moz-quote-pre" wrap="">On Wed, Apr 24, 2024 at 08:50:45AM +0530, Ghimiray, Himal Prasad wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> Hi Rodrigo, The debugfs entry introduced in [PATCH 4/4] of the series offers the same functionality as the modparams provided. Do you perceive any additional value in using this modparam? The behavior of loading the module without using modparams and setting debugfs mode to 2 before executing the workload is identical to loading the driver module with the modparam xe_modparam.wedged_mode = 2. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> yes, they are. But there are situations where the hang could be happening at boot time.</pre> </blockquote> <span style="color: rgb(13, 13, 13); font-family: Söhne, ui-sans-serif, system-ui, -apple-system, "Segoe UI", Roboto, Ubuntu, Cantarell, "Noto Sans", sans-serif, "Helvetica Neue", Arial, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre-wrap; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">Oh, I get it now! With this explanation, patch LGTM Reviewed-by: Himal Prasad Ghimiray <a class="moz-txt-link-rfc2396E" href="mailto:himal.prasad.ghimiray@intel.com"><himal.prasad.ghimiray@intel.com></a> <blockquote type="cite" cite="mid:Zij6Qh1rvGTOG3e6@intel.com"> <pre class="moz-quote-pre" wrap=""> That's what the modparam is for. SV teams wouldn't have a way to debug the hangs on boot. But in general the debugfs is enough for most of the cases and better because it is per device and not for all devices driven by the module. </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> BR Himal struct init_funcs { int (*init)(void); void (*exit)(void); diff --git a/drivers/gpu/drm/xe/xe_module.h b/drivers/gpu/drm/xe/xe_module.h index b369984f08ec..61a0d28a28c8 100644 --- a/drivers/gpu/drm/xe/xe_module.h +++ b/drivers/gpu/drm/xe/xe_module.h @@ -21,6 +21,7 @@ struct xe_modparam { #ifdef CONFIG_PCI_IOV unsigned int max_vfs; #endif + int wedged_mode; }; extern struct xe_modparam xe_modparam; References Visible links 1. <a class="moz-txt-link-freetext" href="mailto:matthew.brost@intel.com">mailto:matthew.brost@intel.com</a> 2. <a class="moz-txt-link-freetext" href="mailto:dhirschfeld@habana.ai">mailto:dhirschfeld@habana.ai</a> 3. <a class="moz-txt-link-freetext" href="mailto:lucas.demarchi@intel.com">mailto:lucas.demarchi@intel.com</a> 4. <a class="moz-txt-link-freetext" href="mailto:alan.previn.teres.alexis@intel.com">mailto:alan.previn.teres.alexis@intel.com</a> 5. <a class="moz-txt-link-freetext" href="mailto:himanshu.somaiya@intel.com">mailto:himanshu.somaiya@intel.com</a> 6. <a class="moz-txt-link-freetext" href="mailto:lucas.demarchi@intel.com">mailto:lucas.demarchi@intel.com</a> 7. <a class="moz-txt-link-freetext" href="mailto:rodrigo.vivi@intel.com">mailto:rodrigo.vivi@intel.com</a> 8. <a class="moz-txt-link-freetext" href="https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n">https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n</a> 9. <a class="moz-txt-link-freetext" href="https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n">https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n</a> </pre> </blockquote> </blockquote> </body> </html>