<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi Michal,<br>
</p>
<div class="moz-cite-prefix">On 4/25/2024 9:15 PM, Michal Wajdeczko
wrote:<br>
</div>
<blockquote type="cite" cite="mid:63adbb9b-ee0e-4a60-866f-135ee59f97dd@intel.com">
<pre class="moz-quote-pre" wrap="">
On 25.04.2024 19:46, Matthew Brost wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Thu, Apr 25, 2024 at 02:18:56PM +0200, Nirmoy Das wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Add engine name to the engine reset and cat error log
which should be useful while debugging.
Signed-off-by: Nirmoy Das <a class="moz-txt-link-rfc2396E" href="mailto:nirmoy.das@intel.com"><nirmoy.das@intel.com></a>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index c7d38469fb46..245e29d095c0 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1655,7 +1655,7 @@ int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
if (unlikely(!q))
return -EPROTO;
- drm_info(&xe->drm, "Engine reset: guc_id=%d", guc_id);
+ drm_info(&xe->drm, "Engine reset: name=%s, guc_id=%d", q->hwe->name, guc_id);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I don't think q->hwe->name name is useful as it might not actually be
exec queue is running. I'd drop that, and replace with string indicating
the hardware engine class.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
and maybe it's also a good time to switch into GT-oriented logs:
- struct xe_device *xe = guc_to_xe(guc);
+ struct xe_gt *gt = guc_to_gt(guc);
xe_gt_info(gt, "Engine reset....</pre>
</blockquote>
<p>Yes, gt log will throw more useful info. I will switch to <span style="white-space: pre-wrap">xe_gt_info/</span><span style="white-space: pre-wrap">xe_gt_dbg.</span></p>
<p><span style="white-space: pre-wrap">
</span></p>
<p><span style="white-space: pre-wrap">Thanks,</span></p>
<p><span style="white-space: pre-wrap">Nirmoy
</span></p>
<blockquote type="cite" cite="mid:63adbb9b-ee0e-4a60-866f-135ee59f97dd@intel.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
/* FIXME: Do error capture, most likely async */
@@ -1690,7 +1690,8 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg,
if (unlikely(!q))
return -EPROTO;
- drm_dbg(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);
+ drm_dbg(&xe->drm, "Engine memory cat error: name=%s, guc_id=%d",
+ q->hwe->name, guc_id);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Same here.
Matt
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> trace_xe_exec_queue_memory_cat_error(q);
/* Treat the same as engine reset */
--
2.42.0
</pre>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>