<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 8/16/2024 10:03 AM,
<a class="moz-txt-link-abbreviated" href="mailto:apoorva.singh@intel.com">apoorva.singh@intel.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20240816080355.897256-1-apoorva.singh@intel.com">
<pre wrap="" class="moz-quote-pre">From: Apoorva Singh <a class="moz-txt-link-rfc2396E" href="mailto:apoorva.singh@intel.com"><apoorva.singh@intel.com></a>
- lrc->bo NULL check is not needed in xe_lrc_snapshot_capture() as
its already been taken care of in xe_lrc_init().</pre>
</blockquote>
<p>It should be rather "it is always initialized in <span
style="white-space: pre-wrap">xe_lrc_init</span>()
". With that <br>
</p>
<p>Reviewed-by: Nirmoy Das <a class="moz-txt-link-rfc2396E" href="mailto:nirmoy.das@intel.com"><nirmoy.das@intel.com></a><br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:20240816080355.897256-1-apoorva.singh@intel.com">
<pre wrap="" class="moz-quote-pre">
Signed-off-by: Apoorva Singh <a class="moz-txt-link-rfc2396E" href="mailto:apoorva.singh@intel.com"><apoorva.singh@intel.com></a>
---
drivers/gpu/drm/xe/xe_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 974a9cd8c379..aec7db39c061 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1649,7 +1649,7 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
if (!snapshot)
return NULL;
- if (lrc->bo && lrc->bo->vm)
+ if (lrc->bo->vm)
xe_vm_get(lrc->bo->vm);
snapshot->context_desc = xe_lrc_ggtt_addr(lrc);
</pre>
</blockquote>
</body>
</html>