<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div dir="ltr" id="divRplyFwdMsg"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Cavitt, Jonathan <jonathan.cavitt@intel.com><br>
<b>Sent:</b> Monday, March 10, 2025 10:18 AM<br>
<b>To:</b> intel-xe@lists.freedesktop.org <intel-xe@lists.freedesktop.org><br>
<b>Cc:</b> Gupta, saurabhg <saurabhg.gupta@intel.com>; Zuo, Alex <alex.zuo@intel.com>; Cavitt, Jonathan <jonathan.cavitt@intel.com>; joonas.lahtinen@linux.intel.com <joonas.lahtinen@linux.intel.com>; Brost, Matthew <matthew.brost@intel.com>; Zhang, Jianxun
<jianxun.zhang@intel.com>; Lin, Shuicheng <shuicheng.lin@intel.com>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org><br>
<b>Subject:</b> [PATCH v7 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults</span>
<div> </div>
</div>
<div class="elementToProof" style="font-size: 11pt;">Add initial declarations for the drm_xe_vm_get_faults ioctl.<br>
<br>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com><br>
---<br>
include/uapi/drm/xe_drm.h | 49 +++++++++++++++++++++++++++++++++++++++<br>
1 file changed, 49 insertions(+)<br>
<br>
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h<br>
index 616916985e3f..90c2fcdbd5c1 100644<br>
--- a/include/uapi/drm/xe_drm.h<br>
+++ b/include/uapi/drm/xe_drm.h<br>
@@ -81,6 +81,7 @@ extern "C" {<br>
* - &DRM_IOCTL_XE_EXEC<br>
* - &DRM_IOCTL_XE_WAIT_USER_FENCE<br>
* - &DRM_IOCTL_XE_OBSERVATION<br>
+ * - %DRM_IOCTL_XE_VM_GET_FAULTS<br>
*/<br>
<br>
/*<br>
@@ -102,6 +103,7 @@ extern "C" {<br>
#define DRM_XE_EXEC 0x09<br>
#define DRM_XE_WAIT_USER_FENCE 0x0a<br>
#define DRM_XE_OBSERVATION 0x0b<br>
+#define DRM_XE_VM_GET_FAULTS 0x0c<br>
<br>
/* Must be kept compact -- no holes */<br>
<br>
@@ -117,6 +119,7 @@ extern "C" {<br>
#define DRM_IOCTL_XE_EXEC DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC, struct drm_xe_exec)<br>
#define DRM_IOCTL_XE_WAIT_USER_FENCE DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_WAIT_USER_FENCE, struct drm_xe_wait_user_fence)<br>
#define DRM_IOCTL_XE_OBSERVATION DRM_IOW(DRM_COMMAND_BASE + DRM_XE_OBSERVATION, struct drm_xe_observation_param)<br>
+#define DRM_IOCTL_XE_VM_GET_FAULTS DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_GET_FAULTS, struct drm_xe_vm_get_faults)<br>
<br>
/**<br>
* DOC: Xe IOCTL Extensions<br>
@@ -1189,6 +1192,52 @@ struct drm_xe_vm_bind {<br>
__u64 reserved[2];<br>
};<br>
<br>
+struct xe_vm_fault {<br>
+ /** @address: Address of the fault, if relevant */<br>
+ __u64 address;<br>
+#define DRM_XE_FAULT_ADDRESS_TYPE_NONE_EXT 0<br>
+#define DRM_XE_FAULT_ADDRESS_TYPE_READ_INVALID_EXT 1<br>
+#define DRM_XE_FAULT_ADDRESS_TYPE_WRITE_INVALID_EXT 2<br>
+ /** @address_type: , if relevant */<br>
+ __u32 address_type;<br>
+ /**<br>
+ * @address_precision: Precision of faulted address, if relevant.<br>
+ * Currently only SZ_4K.<br>
+ */<br>
+ __u32 address_precision;</div>
<div class="elementToProof" style="font-size: 11pt;">There could be a few more fields we need KMD to report to meet basic support of the VK extension. I am going through them and will let you know.<br>
+ /** @reserved: MBZ */<br>
+ __u64 reserved[3];<br>
+};<br>
+<br>
+/**<br>
+ * struct drm_xe_vm_get_faults - Input of &DRM_IOCTL_XE_VM_GET_FAULTS<br>
+ *<br>
+ * The user provides a VM ID, and the ioctl will<br>
+ *<br>
+ */<br>
+struct drm_xe_vm_get_faults {<br>
+ /** @extensions: Pointer to the first extension struct, if any */<br>
+ __u64 extensions;<br>
+<br>
+ /** @vm_id: The ID of the VM to query the properties of */<br>
+ __u32 vm_id;<br>
+<br>
+ /** @size: Size to allocate for @ptr */<br>
+ __u32 size;</div>
<div class="elementToProof" style="font-size: 11pt;">If this for the total size in byte of the memory of `faults` array, it seems redundant. We can just use `fault_count`. I think removing it streamlines the interface design. Some code like dividing ops in
patch 4/6 can be saved, possibly.</div>
<div class="elementToProof" style="font-size: 11pt; color: rgb(0, 0, 0);">Knowing fault_count and size of struct xe_vm_fault is sufficient to UMD to allocate exact size of the memory too.</div>
<div class="elementToProof" style="font-size: 11pt;">+<br>
+ /** @fault_count: Number of faults to be returned */<br>
+ __u32 fault_count;<br>
+<br>
+ /** @pad: MBZ */<br>
+ __u32 pad;<br>
+<br>
+ /** @reserved: MBZ */<br>
+ __u64 reserved[2];<br>
+<br>
+ /** @faults: Pointer to user-defined array of xe_vm_fault of flexible size */<br>
+ __u64 faults;<br>
+};<br>
+<br>
/**<br>
* struct drm_xe_exec_queue_create - Input of &DRM_IOCTL_XE_EXEC_QUEUE_CREATE<br>
*<br>
--<br>
2.43.0<br>
<br>
</div>
</body>
</html>