<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> You can rephrase commit title to: Add debugfs for G-state and PCIe link states residency On 03-06-2025 23:42, Soham Purkait wrote: <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre"> Add two debugfs node named dgfx_pkg_residencies and dgfx_link_state_residencys in order to obtain the G-State residency counter values for G2, G6, G8, G10 & ModS and the pcie link state residency counter values for L0, L1 & L1.2 respectively.</pre> </blockquote> 1. what are the changes done in v2 version of this patch ? <pre wrap="" class="moz-quote-pre">2. rename dgfx_link_state_residencys -> dgfx_pcie_link_residencies</pre> 3. Commit message can be changed to, Add debug nodes, dgfx_pkg_residencies for G-states (G2, G6, G8, G10, ModS) and and dgfx_pcie_link_residencies for PCIe link states(L0, L1, L1_2) residency counters. <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">Signed-off-by: Soham Purkait <a class="moz-txt-link-rfc2396E" href="mailto:soham.purkait@intel.com"><soham.purkait@intel.com></a> --- drivers/gpu/drm/xe/xe_debugfs.c | 99 +++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c index d83cd6ed3fa8..c339f05ce42e 100644 --- a/drivers/gpu/drm/xe/xe_debugfs.c +++ b/drivers/gpu/drm/xe/xe_debugfs.c @@ -11,16 +11,19 @@ #include <drm/drm_debugfs.h> +#include "regs/xe_pmt.h" #include "xe_bo.h" #include "xe_device.h" #include "xe_force_wake.h" #include "xe_gt_debugfs.h" #include "xe_gt_printk.h" #include "xe_guc_ads.h" +#include "xe_mmio.h" #include "xe_pm.h" #include "xe_pxp_debugfs.h" #include "xe_sriov.h" #include "xe_step.h" +#include "xe_vsec.h" #ifdef CONFIG_DRM_XE_DEBUG #include "xe_bo_evict.h" @@ -185,6 +188,86 @@ static ssize_t wedged_mode_set(struct file *f, const char __user *ubuf, return size; } +static int read_residency_counter(struct xe_device *xe, struct xe_mmio *mmio, + u64 *dst, u32 offset, char *name) +{ + int ret = xe_pmt_telem_read(to_pci_dev(xe->drm.dev), + xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), + dst, offset, sizeof(u64));</pre> </blockquote> int ret = 0; Please separate declaration of ret, before usage. <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ if (ret != sizeof(u64))</pre> </blockquote> sizeof(dst) <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ drm_warn(&xe->drm, "%s residency counter failed to read, ret %d\n", name, ret);</pre> </blockquote> residency counter read failed <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ + return 0; +} + +static ssize_t dgfx_pkg_residencies_show(struct file *f, char __user *ubuf, + size_t size, loff_t *pos) +{ + u64 g_states;</pre> </blockquote> you can rename g_states -> counter, i.e u64 counter = 0; <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ char buf[256];</pre> </blockquote> We can avoid this buf by using drm_info_list, similar to sriov_info in the same file static const struct drm_info_list debugfs_list[] = { {"info", info, 0}, { .name = "sriov_info", .show = sriov_info, }, }; <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ int len = 0; + struct xe_device *xe; + struct xe_mmio *mmio; + + xe = file_inode(f)->i_private; + xe_pm_runtime_get(xe); + mmio = xe_root_tile_mmio(xe); + + g_states = 0;</pre> </blockquote> <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre">+ read_residency_counter(xe, mmio, &g_states, BMG_G2_RESIDENCY_OFFSET, "G2"); + len = scnprintf(buf, sizeof(buf), "Package G2: %llu\n", g_states); + + g_states = 0; + read_residency_counter(xe, mmio, &g_states, BMG_G6_RESIDENCY_OFFSET, "G6"); + len += scnprintf(buf + len, sizeof(buf) - len, "Package G6: %llu\n", g_states); + + g_states = 0; + read_residency_counter(xe, mmio, &g_states, BMG_G8_RESIDENCY_OFFSET, "G8"); + len += scnprintf(buf + len, sizeof(buf) - len, "Package G8: %llu\n", g_states); + + g_states = 0; + read_residency_counter(xe, mmio, &g_states, BMG_G10_RESIDENCY_OFFSET, "G10"); + len += scnprintf(buf + len, sizeof(buf) - len, "Package G10: %llu\n", g_states); + + g_states = 0; + read_residency_counter(xe, mmio, &g_states, BMG_MODS_RESIDENCY_OFFSET, "ModS"); + len += scnprintf(buf + len, sizeof(buf) - len, "Package ModS: %llu\n", g_states); + + xe_pm_runtime_put(xe); + return simple_read_from_buffer(ubuf, size, pos, buf, len); +} + +static ssize_t dgfx_link_state_residencys_show(struct file *f, char __user *ubuf, + size_t size, loff_t *pos) +{ + u64 link_res; + char buf[256]; + int len = 0; + struct xe_device *xe; + struct xe_mmio *mmio; + + xe = file_inode(f)->i_private; + xe_pm_runtime_get(xe); + mmio = xe_root_tile_mmio(xe); + + link_res = 0; + read_residency_counter(xe, mmio, &link_res, PCIE_LINK_L0_RESIDENCY_COUNTER, "PCIE LINK L0"); + len = scnprintf(buf, sizeof(buf), "PCIE LINK L0 RESIDENCY : %llu\n", link_res); + + link_res = 0; + read_residency_counter(xe, mmio, &link_res, PCIE_LINK_L1_RESIDENCY_COUNTER, "PCIE LINK L1"); + len += scnprintf(buf + len, sizeof(buf) - len, "PCIE LINK L1 RESIDENCY : %llu\n", link_res); + + link_res = 0; + read_residency_counter(xe, mmio, &link_res, + PCIE_LINK_L1_2_RESIDENCY_COUNTER, "PCIE LINK L1.2"); + len += scnprintf(buf + len, sizeof(buf) - len, + "PCIE LINK L1.2 RESIDENCY : %llu\n", link_res); + + xe_pm_runtime_put(xe); + return simple_read_from_buffer(ubuf, size, pos, buf, len); +} + static const struct file_operations wedged_mode_fops = { .owner = THIS_MODULE, .read = wedged_mode_show, @@ -226,6 +309,16 @@ static const struct file_operations atomic_svm_timeslice_ms_fops = { .write = atomic_svm_timeslice_ms_set, }; +static const struct file_operations dgfx_pkg_residencies_fops = { + .owner = THIS_MODULE, + .read = dgfx_pkg_residencies_show, +}; + +static const struct file_operations dgfx_link_state_residencys_fops = { + .owner = THIS_MODULE, + .read = dgfx_link_state_residencys_show, +}; + void xe_debugfs_register(struct xe_device *xe) { struct ttm_device *bdev = &xe->ttm; @@ -249,6 +342,12 @@ void xe_debugfs_register(struct xe_device *xe) debugfs_create_file("atomic_svm_timeslice_ms", 0600, root, xe, &atomic_svm_timeslice_ms_fops); + debugfs_create_file("dgfx_pkg_residencies", 0444, root, xe, + &dgfx_pkg_residencies_fops); + + debugfs_create_file("dgfx_link_state_residencys", 0444, root, xe, + &dgfx_link_state_residencys_fops); +</pre> </blockquote> You can drm_info_list to create the debugfs as mentioned above. <blockquote type="cite" cite="mid:20250603181205.1680363-2-soham.purkait@intel.com"> <pre wrap="" class="moz-quote-pre"> for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; ++mem_type) { man = ttm_manager_type(bdev, mem_type); </pre> </blockquote> </body> </html>