<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
<b>>Subject:</b> [PATCH] drm/i915/display: handle >return value in intel_sdvo_enable_hotplug</div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
<br>
</div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
The subject does not match what you are doing in the patch maybe fix that .</div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
Sorry for the noise my email client seems to be acting weird.(may still not be working right so sorry again will probably be fixed by the next reply I send :D)</div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
Other than that everything </div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
LGTM,</div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com></div>
<div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">
<br>
</div>
<div dir="auto" id="mail-editor-reference-message-container">
<div id="divRplyFwdMsg" style="font-size: 11pt;" dir="auto"></div>
><br>
<meta name="Generator" content="Microsoft Exchange Server">
<div dir="auto" class="PlainText" style="font-size: 11pt;">>Report in log if intel_sdvo_enable_hotplug failed<br>
><br>
>Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com><br>
>---<br>
>drivers/gpu/drm/i915/display/intel_sdvo.c | 6 >++++--<br>
>1 file changed, 4 insertions(+), 2 deletions(-)<br>
><br>
>diff --git >a/drivers/gpu/drm/i915/display/intel_sdvo.c >b/drivers/gpu/drm/i915/display/intel_sdvo.c<br>
>index 87aff2754f69..99a5ef1401a8 100644<br>
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c<br>
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c<br>
>@@ -2052,8 +2052,10 @@ static void >intel_sdvo_enable_hotplug(struct intel_encoder >*encoder)<br>
>{<br>
> struct intel_sdvo *intel_sdvo = to_sdvo(encoder);<br>
><br>
>- intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,<br>
>- &intel_sdvo->hotplug_active, 2);<br>
>+ if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,<br>
>+ &intel_sdvo->hotplug_active, 2))<br>
>+ drm_warn(intel_sdvo->base.base.dev,<br>
>+ "Failed to enable hotplug on SDVO encoder\n");<br>
>}<br>
><br>
>static enum intel_hotplug_state<br>
<br>
<br>
</div>
<br>
</div>
</body>
</html>