[LDTP-Dev] [PATCH] fix for checkrow and uncheckrow in table.c

[Nagappan]

Hi Prem,
    Patch looks fine, Please check in.

Thanks
Nagappan

jpremkumar wrote:
> Hi
>
> I have attached the patch for fixing checkrow and uncheckrow APIs in
> table.c. Actually, these two APIs accept optional column value in
> tree-table.c but the same thing hasn't been done in table.c. Hopefully
> we wont face these issues when we complete the merging of table.c and
> tree-table.c which is due for next dot release.
>
> Please review the patch.
>
> Thanks
> Premkumar
>
> Index: table.c
> ===================================================================
> RCS file: /cvs/pyldtp/table.c,v
> retrieving revision 1.43
> diff -r1.43 table.c
> 553c553
> < static int check_row (Accessible *object, int row)
> ---
>   
>> static int check_row (Accessible *object, int row, int col)
>>     
> 578c578,588
> <   cell = AccessibleTable_getAccessibleAt (table, row, 0);
> ---
>   
>>   if (col < 0 || col >= n_cols)
>>     {
>>       char *msg;
>>       msg = g_strdup_printf ("Column %d doesnot exist in table", col);
>>       log_msg (LOG_CAUSE, msg);
>>       free (msg);
>>       Accessible_unref (table);
>>       return 0;
>>     }
>>
>>   cell = AccessibleTable_getAccessibleAt (table, row, col);
>>     
> 607c617
> < static int uncheck_row (Accessible *object, int row)
> ---
>   
>> static int uncheck_row (Accessible *object, int row, int col)
>>     
> 632c642,653
> <   cell = AccessibleTable_getAccessibleAt (table, row, 0);
> ---
>   
>>   if (col < 0 || col >= n_cols)
>>     {
>>       char *msg;
>>       msg = g_strdup_printf ("Column %d doesnot exist in table", col);
>>       log_msg (LOG_CAUSE, msg);
>>       free (msg);
>>       Accessible_unref (table);
>>       return 0;
>>     }
>>
>>
>>   cell = AccessibleTable_getAccessibleAt (table, row, col);
>>     
> 1055a1077
>   
>> 	int col;
>>     
> 1057c1079,1080
> < 	return check_row (object, row);
> ---
>   
>> 	col = atoi (params[1]);
>> 	return check_row (object, row, col);
>>     
> 1061a1085
>   
>> 	int col;
>>     
> 1063c1087,1088
> < 	return uncheck_row (object, row);
> ---
>   
>> 	col = atoi (params[1]);
>> 	return uncheck_row (object, row, col);
>>     
>
> _______________________________________________
> Ldtp-dev mailing list
> Ldtp-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/ldtp-dev
>   

-- 
Nagappan A <anagappan at novell.com>
Novell Software Development (I) Pvt. Ltd.
Linux Desktop Testing Project - http://gnomebangalore.org/ldtp/index.php/Main_Page
http://nagappanal.blogspot.com/