[LDTP-Dev] [Bug 349114] Integrate LDTP tests into jhbuild

[jhbuild (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=349114
 jhbuild | general | Ver: unspecified


Frederic Peters changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70364|none                        |commented-on
               Flag|                            |




------- Comment #6 from Frederic Peters  2006-08-08 10:14 UTC -------
modtypes/testmodule.py

- getting display number:

  - why not os.listdir() instead of os.walk()
    - or doing it like debian xvfb-run
      while True:
         if not os.path.exists(...):
             break
         servernum += 1

- xauthority
  - my fault, but xauth last arg (mcookie) should be in hex,
    md5.md5(...).hexdigest()


frontends/autobuild.py

- could _upload_logfile be cut out of ldtp stuff, for easier dogtail (and more)
  integration ?  something like:

   def _upload_ldtp_logfile(self, module):
        test_module = self.modules.modules[module]
        src_dir =  test_module.get_srcdir()
        if not os.path.exists (os.path.join(src_dir, 'run.xml')):
            return
        logfile =
test_module.get_ldtp_log_file(os.path.join(src_dir,'run.xml'))
        if not os.path.exists (logfile):
            return
        self._upload_logfile(module, logfile, 'application/x-ldtp+xml')

   def _upload_logfile(self, module, logfile, mimetype):
        logfd = open(logfile)
        basename = os.path.basename(logfile)
        self.server.attach_file(self.build_id, module, 'test',
                basename, compress_data(logfd.read()), mimetype)
        logfd.close()


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.