[LDTP-Dev] [Bug 349114] Integrate LDTP tests into jhbuild

[jhbuild (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=349114
 jhbuild | general | Ver: unspecified


Frederic Peters changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fpeters at entrouvert.com




------- Comment #2 from Frederic Peters  2006-07-29 16:18 UTC -------
For completeness, here is a copy of my first review, sent by email

A minor thing, I would prefer module imports to each be on their own
lines, especially when mixing standard modules and jhbuild modules.

Another minor thing (I'm reading the diff linearly), avoid space
changes on empty lines, so we get a cleaner diff.

Question, make_option for noxvfb, isn't it duplicated ? (it appears
both in commands/base.py and in command/test.py)

frontends/autobuild.by:
 - unused global modules dict
 - lazy loading, load_tests should only be called the first time the
   value is necessary (end_phase when phase == 'test') (and self.modules
   would then be stored)
 - s/compress_date/compress_data/, just a typo
 - use os.path.join(xx, yy) instead of xx+os.sep+yy

modtypes/testmodule.py:

 - why inherit from AutogenModule ?  wouldn't Package be enough ?  If
   you want to use AutogenModule, don't duplicate code.

 - _check_ldtp_log_file & friends, is all this work necessary,
   formatting a status string and stuff ?  Or would it be enough to
   look for a <pass> node with 0 as value ?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.