libbsd: Branch 'master' - 2 commits
Guillem Jover
guillem at kemper.freedesktop.org
Tue Dec 1 18:48:22 PST 2015
src/Makefile.am | 2 -
src/arc4random.h | 18 +---------
src/arc4random_bsd.h | 86 -------------------------------------------------
src/arc4random_linux.h | 86 -------------------------------------------------
src/arc4random_unix.h | 14 +++++++
src/closefrom.c | 2 -
src/getentropy.c | 2 -
7 files changed, 17 insertions(+), 193 deletions(-)
New commits:
commit 01b77f0dcf7f43fe598d5f6aa34f9edfad418432
Author: Guillem Jover <guillem at hadrons.org>
Date: Wed Dec 2 03:32:13 2015 +0100
Add support for GNU/kFreeBSD for closefrom() and getentropy()
diff --git a/src/closefrom.c b/src/closefrom.c
index c2922e7..962af79 100644
--- a/src/closefrom.c
+++ b/src/closefrom.c
@@ -136,7 +136,7 @@ closefrom_procfs(int lowfd)
int i;
/* Use /proc/self/fd (or /dev/fd on FreeBSD) if it exists. */
-# if defined(__FreeBSD__) || defined(__APPLE__)
+# if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__APPLE__)
path = "/dev/fd";
# else
path = "/proc/self/fd";
diff --git a/src/getentropy.c b/src/getentropy.c
index f22b850..be19d7e 100644
--- a/src/getentropy.c
+++ b/src/getentropy.c
@@ -26,7 +26,7 @@
#if defined(__linux__)
#include "getentropy_linux.c"
-#elif defined(__FreeBSD__)
+#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
#include "arc4random_bsd.c"
#elif defined(__NetBSD__)
#include "arc4random_bsd.c"
commit 75729394af82faf54721cd40c0c8c258954082dc
Author: Guillem Jover <guillem at hadrons.org>
Date: Wed Dec 2 03:08:17 2015 +0100
Unify most arc4random Unix hooks into a single file
The Unix hook should work for most Unix-like systems, move glibc
specific code there and a FreeBSd specific comment, and remove the rest.
Also change the code to always fallback to use the generic Unix code.
This should cover GNU/Hurd and GNU/kFreeBSD among others.
diff --git a/src/Makefile.am b/src/Makefile.am
index cc2b784..9df41a2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -57,8 +57,6 @@ libbsd_la_LDFLAGS = \
libbsd_la_SOURCES = \
arc4random.c \
arc4random.h \
- arc4random_bsd.h \
- arc4random_linux.h \
arc4random_unix.h \
arc4random_openbsd.h \
arc4random_uniform.c \
diff --git a/src/arc4random.h b/src/arc4random.h
index de52922..0887e86 100644
--- a/src/arc4random.h
+++ b/src/arc4random.h
@@ -6,24 +6,10 @@
int
getentropy(void *buf, size_t len);
-#if defined(__linux__)
-#include "arc4random_linux.h"
-#elif defined(__FreeBSD__)
-#include "arc4random_bsd.h"
-#elif defined(__NetBSD__)
-#include "arc4random_bsd.h"
-#elif defined(__OpenBSD__)
+#if defined(__OpenBSD__)
#include "arc4random_openbsd.h"
-#elif defined(__sun)
-#include "arc4random_unix.h"
-#elif defined(__APPLE__)
-#include "arc4random_unix.h"
-#elif defined(_AIX)
-#include "arc4random_unix.h"
-#elif defined(__hpux)
-#include "arc4random_unix.h"
#else
-#error "No arc4random hooks defined for this platform."
+#include "arc4random_unix.h"
#endif
#endif
diff --git a/src/arc4random_bsd.h b/src/arc4random_bsd.h
deleted file mode 100644
index ece2f85..0000000
--- a/src/arc4random_bsd.h
+++ /dev/null
@@ -1,86 +0,0 @@
-/* $OpenBSD: arc4random_freebsd.h,v 1.2 2015/01/15 06:57:18 deraadt Exp $ */
-
-/*
- * Copyright (c) 1996, David Mazieres <dm at uun.org>
- * Copyright (c) 2008, Damien Miller <djm at openbsd.org>
- * Copyright (c) 2013, Markus Friedl <markus at openbsd.org>
- * Copyright (c) 2014, Theo de Raadt <deraadt at openbsd.org>
- *
- * Permission to use, copy, modify, and distribute this software for any
- * purpose with or without fee is hereby granted, provided that the above
- * copyright notice and this permission notice appear in all copies.
- *
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-
-/*
- * Stub functions for portability.
- */
-
-#include <sys/mman.h>
-
-#include <pthread.h>
-#include <signal.h>
-
-static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
-#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
-#define _ARC4_UNLOCK() pthread_mutex_unlock(&arc4random_mtx)
-
-/*
- * Unfortunately, pthread_atfork() is broken on FreeBSD (at least 9 and 10) if
- * a program does not link to -lthr. Callbacks registered with pthread_atfork()
- * appear to fail silently. So, it is not always possible to detect a PID
- * wraparound.
- */
-#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
-
-static inline void
-_getentropy_fail(void)
-{
- raise(SIGKILL);
-}
-
-static volatile sig_atomic_t _rs_forked;
-
-static inline void
-_rs_forkhandler(void)
-{
- _rs_forked = 1;
-}
-
-static inline void
-_rs_forkdetect(void)
-{
- static pid_t _rs_pid = 0;
- pid_t pid = getpid();
-
- if (_rs_pid == 0 || _rs_pid != pid || _rs_forked) {
- _rs_pid = pid;
- _rs_forked = 0;
- if (rs)
- memset(rs, 0, sizeof(*rs));
- }
-}
-
-static inline int
-_rs_allocate(struct _rs **rsp, struct _rsx **rsxp)
-{
- if ((*rsp = mmap(NULL, sizeof(**rsp), PROT_READ|PROT_WRITE,
- MAP_ANON|MAP_PRIVATE, -1, 0)) == MAP_FAILED)
- return (-1);
-
- if ((*rsxp = mmap(NULL, sizeof(**rsxp), PROT_READ|PROT_WRITE,
- MAP_ANON|MAP_PRIVATE, -1, 0)) == MAP_FAILED) {
- munmap(*rsp, sizeof(**rsp));
- return (-1);
- }
-
- _ARC4_ATFORK(_rs_forkhandler);
- return (0);
-}
diff --git a/src/arc4random_linux.h b/src/arc4random_linux.h
deleted file mode 100644
index d61a8db..0000000
--- a/src/arc4random_linux.h
+++ /dev/null
@@ -1,86 +0,0 @@
-/* $OpenBSD: arc4random_linux.h,v 1.8 2014/08/13 06:04:10 deraadt Exp $ */
-
-/*
- * Copyright (c) 1996, David Mazieres <dm at uun.org>
- * Copyright (c) 2008, Damien Miller <djm at openbsd.org>
- * Copyright (c) 2013, Markus Friedl <markus at openbsd.org>
- * Copyright (c) 2014, Theo de Raadt <deraadt at openbsd.org>
- *
- * Permission to use, copy, modify, and distribute this software for any
- * purpose with or without fee is hereby granted, provided that the above
- * copyright notice and this permission notice appear in all copies.
- *
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-
-/*
- * Stub functions for portability.
- */
-
-#include <sys/mman.h>
-
-#include <pthread.h>
-#include <signal.h>
-
-static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
-#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
-#define _ARC4_UNLOCK() pthread_mutex_unlock(&arc4random_mtx)
-
-#ifdef __GLIBC__
-extern void *__dso_handle;
-extern int __register_atfork(void (*)(void), void(*)(void), void (*)(void), void *);
-#define _ARC4_ATFORK(f) __register_atfork(NULL, NULL, (f), __dso_handle)
-#else
-#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
-#endif
-
-static inline void
-_getentropy_fail(void)
-{
- raise(SIGKILL);
-}
-
-static volatile sig_atomic_t _rs_forked;
-
-static inline void
-_rs_forkhandler(void)
-{
- _rs_forked = 1;
-}
-
-static inline void
-_rs_forkdetect(void)
-{
- static pid_t _rs_pid = 0;
- pid_t pid = getpid();
-
- if (_rs_pid == 0 || _rs_pid != pid || _rs_forked) {
- _rs_pid = pid;
- _rs_forked = 0;
- if (rs)
- memset(rs, 0, sizeof(*rs));
- }
-}
-
-static inline int
-_rs_allocate(struct _rs **rsp, struct _rsx **rsxp)
-{
- if ((*rsp = mmap(NULL, sizeof(**rsp), PROT_READ|PROT_WRITE,
- MAP_ANON|MAP_PRIVATE, -1, 0)) == MAP_FAILED)
- return (-1);
-
- if ((*rsxp = mmap(NULL, sizeof(**rsxp), PROT_READ|PROT_WRITE,
- MAP_ANON|MAP_PRIVATE, -1, 0)) == MAP_FAILED) {
- munmap(*rsp, sizeof(**rsp));
- return (-1);
- }
-
- _ARC4_ATFORK(_rs_forkhandler);
- return (0);
-}
diff --git a/src/arc4random_unix.h b/src/arc4random_unix.h
index c200abc..73b0cd5 100644
--- a/src/arc4random_unix.h
+++ b/src/arc4random_unix.h
@@ -1,4 +1,4 @@
-/* $OpenBSD: arc4random_hpux.h,v 1.1 2015/01/06 21:08:11 bcook Exp $ */
+/* $OpenBSD: arc4random_linux.h,v 1.8 2014/08/13 06:04:10 deraadt Exp $ */
/*
* Copyright (c) 1996, David Mazieres <dm at uun.org>
@@ -32,7 +32,19 @@ static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
#define _ARC4_UNLOCK() pthread_mutex_unlock(&arc4random_mtx)
+#ifdef __GLIBC__
+extern void *__dso_handle;
+extern int __register_atfork(void (*)(void), void(*)(void), void (*)(void), void *);
+#define _ARC4_ATFORK(f) __register_atfork(NULL, NULL, (f), __dso_handle)
+#else
+/*
+ * Unfortunately, pthread_atfork() is broken on FreeBSD (at least 9 and 10) if
+ * a program does not link to -lthr. Callbacks registered with pthread_atfork()
+ * appear to fail silently. So, it is not always possible to detect a PID
+ * wraparound.
+ */
#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
+#endif
static inline void
_getentropy_fail(void)
More information about the libbsd
mailing list