[Libburn] Re: Patch to enable arbitrary input fd (updated 2nd submission)

[scdbackup at gmx.net]

Hi,

it came to me that Kernighan & Ritchie probably had similar
discussions in the 70s and invented a compromise remedy:

  typedef int burn_size_t;

to be applied in libburn.h .

Everything which i proposed as (off_t) shall become
(burn_size_t).
The return type of  burn_source.get_size()  and file_size()
should become (burn_size_t), too.

The fact that (burn_size_t) is currently defined as (int)
should prevent any negative side effects on existing code.
Before (burn_size_t) is allowed to change to a more appropriate
implementation, the code of libburn has to be scanned for
problems related to (int).

This change does nothing but to solve my concerns about basing
the proposed API change on an inappropriate data type.
Thus it should be quite harmless.


Derek, if you can agree to this, then you would only have
to decide wether fixed size is restricted to burn_source_file
sources or wether it shall apply to any type of source.
After that, i should be able to produce an acceptable
patch proposal. Hopefully.
 

Have a nice day :)

Thomas