[Libdlo] [PATCH] udlfb: high-throughput urb pool

Andrew Kephart akephart at akephart.org
Fri Dec 17 13:10:13 PST 2010


On Fri, 2010-12-17 at 12:34 -0800, Greg KH wrote:
> On Fri, Dec 17, 2010 at 02:17:34PM -0600, Andrew Kephart wrote:
[some deleted]
> > +static ssize_t metrics_urb_cache_hits_show(struct device *fbdev,
> > +                                  struct device_attribute *a, char *buf) {
> > +       struct fb_info *fb_info = dev_get_drvdata(fbdev);
> > +       struct dlfb_data *dev = fb_info->par;
> > +       return snprintf(buf, PAGE_SIZE, "%u\n",
> > +                       atomic_read(&dev->urb_cache_hits));
> > +}
> 
> All of these "metrics" should go into debugfs, not sysfs, in the end, as
> that is what it is there for.
> 
> thanks,
> 
> greg k-h

Sounds reasonable.  Will do.

-andrew



More information about the Libdlo mailing list