Build warning/error in libmbim

Aleksander Morgado aleksander at lanedo.com
Fri May 17 14:10:27 PDT 2013


Hey!

> 
> I get this warnings, that seems to be treated as error with my compiler
> (default in Ubuntu 13.04):
> 
> mbim-message.c: In function 'mbim_message_open_done_get_result':
> mbim-message.c:1402:18: error: format not a string literal and no format
> arguments [-Werror=format-security]
> mbim-message.c: In function 'mbim_message_close_done_get_result':
> mbim-message.c:1471:18: error: format not a string literal and no format
> arguments [-Werror=format-security]
> mbim-message.c: In function 'mbim_message_command_done_get_result':
> mbim-message.c:1809:18: error: format not a string literal and no format
> arguments [-Werror=format-security]
> cc1: all warnings being treated as errors
> 
> Attached patch to fix it. Please avoid errors before making releases to
> avoid these strict compilers.
> 

I added -Wformat-security to the default list of warnings to use.

And also pushed your fix after some whitespace alignment fixes.

Thanks!

-- 
Aleksander


More information about the libmbim-devel mailing list