Adding new MBIM extension CID?

Aleksander Morgado aleksander at aleksander.es
Thu Apr 10 07:06:33 PDT 2014


On Thu, Apr 10, 2014 at 2:40 PM, Arnaud Desmier <adesmier at sequans.com> wrote:
> OK, so I enabled again mbim-uuid.h within generated/Makefile.am.
>
> But instead of writing a mbim_service_custom_get_string I wrote a
> mbim_get_service_string. This function can retrieve service nickname for any
> service and is called instead of mbim_service_get_string that is
> automatically generated.
>
> I know the difference between mbim_service_get_string and
> mbim_get_service_string is really tiny and can confuse but I have no better
> name.

Well... that's pretty confusing actually.

How about mbim_service_lookup_name()? The method actually looks for
the service name; either directly via the enum's get_string() for the
standard ones or looking for a match in the registered ones.

Also, the method shouldn't received a MbimService; it should get a
guint, as the registered services are not included in the MbimService
enum (e.g. you cannot get a registered service value as a GEnum).

-- 
Aleksander
https://aleksander.es


More information about the libmbim-devel mailing list