[PATCH 1/2] libmbim-glib: remove invalid Context Type UUID conversion

Aleksander Morgado aleksander at aleksander.es
Mon Feb 10 10:58:39 PST 2014


On 10/02/14 18:23, Ben Chan wrote:
> This patch removes the following invalid conversion from UUID_DSS to a
> MBIM Context Type enumeration type:
> 
> mbim-uuid.c:343:16: error: implicit conversion from enumeration type 'MbimService' to
>       different enumeration type 'MbimContextType' [-Werror,-Wenum-conversion]
>         return MBIM_SERVICE_DSS;
>         ~~~~~~ ^~~~~~~~~~~~~~~~
> ---

Pushed, thanks.

>  src/libmbim-glib/mbim-uuid.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/libmbim-glib/mbim-uuid.c b/src/libmbim-glib/mbim-uuid.c
> index 7c7160e..f25cf2f 100644
> --- a/src/libmbim-glib/mbim-uuid.c
> +++ b/src/libmbim-glib/mbim-uuid.c
> @@ -339,9 +339,6 @@ mbim_uuid_from_context_type (MbimContextType context_type)
>  MbimContextType
>  mbim_uuid_to_context_type (const MbimUuid *uuid)
>  {
> -    if (mbim_uuid_cmp (uuid, &uuid_dss))
> -        return MBIM_SERVICE_DSS;
> -
>      if (mbim_uuid_cmp (uuid, &uuid_context_type_none))
>          return MBIM_CONTEXT_TYPE_NONE;
>  
> 


-- 
Aleksander
https://aleksander.es


More information about the libmbim-devel mailing list