[PATCH] libmm-glib: fix typo in MbimRegistrationFlag

Ben Chan benchan at chromium.org
Tue Feb 18 20:27:33 CET 2014


This patch renames 'MBIM_REGISTRATION_FLAG_MANUAL_PACKET_SERVICE_AUTOMATIC_ATTACH' in
MbimRegistrationFlag to 'MBIM_REGISTRATION_FLAG_PACKET_SERVICE_AUTOMATIC_ATTACH' to be
consistent with the MBIM specification.
---
Hi Aleksander,

I think this rename shouldn't be too disruptive as neither libmbim nor
ModemManager currently uses
'MBIM_REGISTRATION_FLAG_MANUAL_PACKET_SERVICE_AUTOMATIC_ATTACH' in code.

Thanks,
Ben

 src/libmbim-glib/mbim-enums.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libmbim-glib/mbim-enums.h b/src/libmbim-glib/mbim-enums.h
index 6275537..38e12f0 100644
--- a/src/libmbim-glib/mbim-enums.h
+++ b/src/libmbim-glib/mbim-enums.h
@@ -449,14 +449,14 @@ typedef enum {
  * MbimRegistrationFlag:
  * @MBIM_REGISTRATION_FLAG_NONE: None.
  * @MBIM_REGISTRATION_FLAG_MANUAL_SELECTION_NOT_AVAILABLE: Network doesn't support manual network selection.
- * @MBIM_REGISTRATION_FLAG_MANUAL_PACKET_SERVICE_AUTOMATIC_ATTACH: Modem should auto-attach to the network after registration.
+ * @MBIM_REGISTRATION_FLAG_PACKET_SERVICE_AUTOMATIC_ATTACH: Modem should auto-attach to the network after registration.
  *
  * Registration flags.
  */
 typedef enum {
-    MBIM_REGISTRATION_FLAG_NONE                                   = 0,
-    MBIM_REGISTRATION_FLAG_MANUAL_SELECTION_NOT_AVAILABLE         = 1 << 0,
-    MBIM_REGISTRATION_FLAG_MANUAL_PACKET_SERVICE_AUTOMATIC_ATTACH = 1 << 2,
+    MBIM_REGISTRATION_FLAG_NONE                            = 0,
+    MBIM_REGISTRATION_FLAG_MANUAL_SELECTION_NOT_AVAILABLE  = 1 << 0,
+    MBIM_REGISTRATION_FLAG_PACKET_SERVICE_AUTOMATIC_ATTACH = 1 << 2,
 } MbimRegistrationFlag;
 
 /*****************************************************************************/
-- 
1.9.0.rc1.175.g0b1dcb5



More information about the libmbim-devel mailing list