[PATCH] libmbim-glib: fix typo in MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST
benchan at chromium.org
Wed Feb 19 10:07:29 PST 2014
On Wed, Feb 19, 2014 at 3:57 AM, Aleksander Morgado <
aleksander at aleksander.es> wrote:
> On Tue, Feb 18, 2014 at 9:42 PM, Ben Chan <benchan at chromium.org> wrote:
> > This patch renames 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBER_LIST' to
> > 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST' to be consistent with the MBIM
> > specification. This CID is for subscribing notifications for CIDs that
> > the host is interested in, and is not related to mobile 'subscriber'.
> > ---
> > Aleksander,
> > We may want to bump the version of libmbim to make it easier to align
> with the
> > ModemManager code. How do you think?
> Ok, this one is more problematic :)
> Do you have more of these? I think I'll create a branch to handle all
> the API break, and once we have some more we can tag a development
> version with all these changes, and directly bump the requirement in
> ModemManager git master. We'll need to sync releases afterwards, or
> even add some additional MBIM_CHECK_VERSION() checks in the current
> stable version.
Yeah, let's put this on hold. I'm going through the API and see if any
further change is needed.
> > BTW, I didn't update
> MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBER_LIST in NEWS :)
> No worries, I'll get to update NEWS myself before the next release.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the libmbim-devel