[PATCH] basic-connect,stk: make naming more consistent

Aleksander Morgado aleksander at aleksander.es
Thu Feb 20 00:57:18 PST 2014


On 20/02/14 08:16, Ben Chan wrote:
> Also fixes a few indentation issues.
> ---

Pushed to git master; just variable name changes in the generated code
so not a big deal.

>  data/mbim-service-basic-connect.json | 8 ++++----
>  data/mbim-service-stk.json           | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/data/mbim-service-basic-connect.json b/data/mbim-service-basic-connect.json
> index 7a32409..8656477 100644
> --- a/data/mbim-service-basic-connect.json
> +++ b/data/mbim-service-basic-connect.json
> @@ -53,7 +53,7 @@
>      "response" : [ { "name"          : "ReadyState",
>                       "format"        : "guint32",
>                       "public-format" : "MbimSubscriberReadyState" },
> -                   { "name"   : "SubscriberID",
> +                   { "name"   : "SubscriberId",
>                       "format" : "string" },
>                     { "name"   : "SimIccId",
>                       "format" : "string" },
> @@ -77,13 +77,13 @@
>      "response"     : [ { "name"          : "HwRadioState",
>                           "format"        : "guint32",
>                           "public-format" : "MbimRadioSwitchState" },
> -			           { "name"          : "SwRadioState",
> +                       { "name"          : "SwRadioState",
>                           "format"        : "guint32",
>                           "public-format" : "MbimRadioSwitchState" } ],
>      "notification" : [ { "name"          : "HwRadioState",
>                           "format"        : "guint32",
>                           "public-format" : "MbimRadioSwitchState" },
> -			           { "name"          : "SwRadioState",
> +                       { "name"          : "SwRadioState",
>                           "format"        : "guint32",
>                           "public-format" : "MbimRadioSwitchState" } ] },
>  
> @@ -173,7 +173,7 @@
>                     { "name"          : "CellularClass",
>                       "format"        : "guint32",
>                       "public-format" : "MbimCellularClass" },
> -                   { "name"   : "RSSI",
> +                   { "name"   : "Rssi",
>                       "format" : "guint32" },
>                     { "name"   : "ErrorRate",
>                       "format" : "guint32" } ] },
> diff --git a/data/mbim-service-stk.json b/data/mbim-service-stk.json
> index 2b9bbfe..d470542 100644
> --- a/data/mbim-service-stk.json
> +++ b/data/mbim-service-stk.json
> @@ -1,15 +1,15 @@
>  
>  [
> -    // *********************************************************************************
> -    { "type" : "Service",
> -      "name" : "STK" },
> +  // *********************************************************************************
> +  { "type" : "Service",
> +    "name" : "STK" },
>  
>    // *********************************************************************************
>    { "name"         : "Pac",
>      "service"      : "STK",
>      "type"         : "Command",
>      "query"        : [],
> -    "set"          : [ { "name"       : "PacHostcontrol",
> +    "set"          : [ { "name"       : "PacHostControl",
>                           "format"     : "byte-array",
>                           "array-size" : "32" } ],
>  
> 


-- 
Aleksander
https://aleksander.es


More information about the libmbim-devel mailing list