[PATCH] libmbim-glib: fix typo in MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST

[Dan Williams]

On Thu, 2014-02-20 at 09:58 +0100, Aleksander Morgado wrote:
> On 19/02/14 19:07, Ben Chan wrote:
> >> > On Tue, Feb 18, 2014 at 9:42 PM, Ben Chan <benchan at chromium.org> wrote:
> >>> > > This patch renames 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBER_LIST' to
> >>> > > 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST' to be consistent with the MBIM
> >>> > > specification. This CID is for subscribing notifications for CIDs that
> >>> > > the host is interested in, and is not related to mobile 'subscriber'.
> >>> > > ---
> >>> > > Aleksander,
> >>> > >
> >>> > > We may want to bump the version of libmbim to make it easier to align
> >> > with the
> >>> > > ModemManager code. How do you think?
> >>> > >
> >> >
> >> > Ok, this one is more problematic :)
> >> >
> >> > Do you have more of these? I think I'll create a branch to handle all
> >> > the API break, and once we have some more we can tag a development
> >> > version with all these changes, and directly bump the requirement in
> >> > ModemManager git master. We'll need to sync releases afterwards, or
> >> > even add some additional MBIM_CHECK_VERSION() checks in the current
> >> > stable version.
> >> >
> >> >
> > Yeah, let's put this on hold. I'm going through the API and see if any
> > further change is needed.
> > 
> > 
> > 
> 
> I pushed this patch to a new 'next/api-breaks' branch; let's keep the
> breaks all together and we'll handle it properly in the next release.

At least with this specific patch, it seems quite possible to #define
the old name to the new name, and provide a compat function to call the
new function.  Mark both as deprecated in the code docs.  Then we don't
have an API break?

Dan