[PATCH] mbimcli: check status code in command-done message before parsing response

Aleksander Morgado aleksander at aleksander.es
Fri Feb 28 00:36:03 PST 2014


On Fri, Feb 28, 2014 at 9:31 AM, Bjørn Mork <bjorn at mork.no> wrote:
>>> Hi Aleksander,
>>>
>>> The error handling code seems quite repetitive. Perhaps we can later refactor
>>> the common code into some helper function.
>>>
>>
>> Yeah, we could do that. But then, we still need to handle the
>> non-standard cases where a status error code is given along with a valid
>> information buffer (i.e. the helper function will be only for a subset
>> of the cases).
>
> The non-standard cases are few and well defined. You could push the list
> of exceptions to the helper, maybe?


Sure, of course.

-- 
Aleksander
https://aleksander.es


More information about the libmbim-devel mailing list