[PATCH] libmbim: Add mbim-proxy support

[Greg Suarez]

On Fri, May 30, 2014 at 4:41 AM, Aleksander Morgado <
aleksander at aleksander.es> wrote:

> On Fri, May 30, 2014 at 10:41 AM, Bjørn Mork <bjorn at mork.no> wrote:
> >>> So what I'm doing is if a client has sent the
> >>> MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST
> >>> it will only receive indications from that list.
> >>
> >> Yes, unless there is an indication coming which isn't by default
> >> enabled in any client. If there is an indication not configured by any
> >> client, then it should go to all.
> >
> > I'm not sure about this.  You will probably hit this due to races
> > between disconnecting clients and proxy<->modem communication. Avoiding
> > that is going to be hard, because the indications can already be
> > buffered in both modem and driver at the time you attempt to disable
> > them.  OK, it can be fixed using a grace period.  But it's going to be a
> > mess...  And I don't think it's worth messing up stuff for spec
> > compliant modems and clients, just to paper over a possible(?) modem
> > firmware bug.
>
> I'm kind of getting convinced that it may not be worth trying to
> manage that in the proxy, especially when we don't know of any modem
> behaving correctly w.r.t. indications being sent when not supposed to
> (or do we know of any).
>
> Greg, will leave this up to you, as I guess you'll test it and have
> more insights on how it's going to work within the proxy. If you think
> that it is not worth sending to all clients notifications that arrived
> when no client had them configured, let's just filter them out in the
> proxy itself.
>
> Ok, I don't think that it's worth it, so I'll filter it out.

Greg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libmbim-devel/attachments/20140602/84eba699/attachment.html>