[PATCH] libmbim-glib, proxy: Filter indications based on MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST

[Greg Suarez]

On Mon, Jun 23, 2014 at 12:38 PM, Aleksander Morgado <
aleksander at aleksander.es> wrote:

> On Mon, Jun 23, 2014 at 8:52 PM, Greg Suarez <gpsuarez2512 at gmail.com>
> wrote:
> >> Another flow:
> >>  * Client A starts, and by default expects standard indications.
> >>  * Client B starts, and by default expects standard indications.
> >>  * At this point, all standard indications should go to both clients A
> and
> >> B.
> >>  * Client B unregisters itself from all standard indications, and
> >> registers some non-standard ones.
> >>  * At this point, all standard indications should go to client A, and
> >> client B should only get those non-standard indications it was
> >> registered for.
> >
> >
> > The current patch already handles this flow.  Since the client provides
> only
> > the
> > services and cids that it expects to receive in the
> > MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST,
> > the patch saves the MBIM_DEVICES_SERVICE_SUBSCRIBE_LIST and uses it to
> check
> > if an
> > indication should be passed on to the client.  So if Client-B unregisters
> > from a standard service it will
> > not receive those indications.  And since the proxy will never actually
> > unregister from standard services
> > with the actual device, Client A will continue to receive indications
> from
> > standard services.
>
> But then how is the current code handling standard vs non-standard
> services? In other words, if the client doesn't ever send a
> DEVICE_SERVICE_SUBSCRIBE_LIST, what will happen with standard and
> non-standard indications?
>
> Currently they're handled the same, I will implement filtering out
non-standard indications until
the client registers via the DEVICE_SERVICE_SUBSCRIBE_LIST.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libmbim-devel/attachments/20140623/90416bce/attachment.html>