QMI via MBIM for "FCC Authentication" fix

[Aleksander Morgado]

On Sat, Aug 1, 2015 at 11:07 PM, Collin McMillan <cmc at nd.edu> wrote:
> Here is a utility that uses libmbim to issue the 0x555F command through the
> QMI-over-MBIM service.
>
> I also attached a patch for libmbim-1.12.2 that includes the QMI-over-MBIM
> service.  Note that I had to modify the mbim-codegen files.  The function
> _mbim_struct_builder_append_byte_array in mbim_message.c was padding the
> output to multiples of 4. I had to add another flag (permit_padding) to
> _mbim_struct_builder_append_byte_array and
> _mbim_command_builder_append_byte_array, and the associated codegen files.
> This alters the behavior so that types of unsized-byte-array are NOT padded.
> This could have unforeseen consequences, but all the tests still passed...
>
> With the new QMI-over-MBIM service in libmbim, it should not be that
> difficult to add the MBIM layer to libqmi (famous last words).
>
> I believe this patch and utility will fix this issue for modems that do not
> cooperate on the QMI interface directly:
> https://bugzilla.kernel.org/show_bug.cgi?id=92101

Looks pretty good!

The libmbim patch has some wrong indentations (using tabs instead of
spaces), but I can clean that up myself.

Your tool is also good, but why not add it as a new command to
mbimcli? we could have a new "--qmi-dms-set-fcc-authentication"
action; I think it's totally worth it, even as it is without the QMI
over MBIM transport logic.

-- 
Aleksander
https://aleksander.es