[PATCH] mbimcli: fix username/password checks with the '--connect' action

[Aleksander Morgado]

On Thu, Sep 10, 2015 at 12:54 AM, David Ward <david.ward at ll.mit.edu> wrote:
> Fixes: 4e58451a744dbc3f086e9c1dd2d7469ff70d50ef ("mbimcli: add support for Basic Connect session IDs")
> Signed-off-by: David Ward <david.ward at ll.mit.edu>

Pushed to git master, mbim-1-10 and mbim-1-12, thanks!

> ---
>  src/mbimcli/mbimcli-basic-connect.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mbimcli/mbimcli-basic-connect.c b/src/mbimcli/mbimcli-basic-connect.c
> index 9b74677..efdd8be 100644
> --- a/src/mbimcli/mbimcli-basic-connect.c
> +++ b/src/mbimcli/mbimcli-basic-connect.c
> @@ -1004,12 +1004,12 @@ set_connect_activate_parse (const gchar       *str,
>      }
>
>      if (props.auth_protocol == MBIM_AUTH_PROTOCOL_NONE) {
> -        if (username || password) {
> +        if (props.username || props.password) {
>              g_printerr ("error: username or password requires an auth protocol\n");
>              goto error;
>          }
>      } else {
> -        if (!username) {
> +        if (!props.username) {
>              g_printerr ("error: auth protocol requires a username\n");
>              goto error;
>          }
> --
> 1.7.1
>
> _______________________________________________
> libmbim-devel mailing list
> libmbim-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libmbim-devel



-- 
Aleksander
https://aleksander.es