Port reopen hack for Sierra Wireless EM7345
ejcaruso at chromium.org
Mon Aug 7 18:20:53 UTC 2017
On Sun, Aug 6, 2017 at 8:08 AM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> Hey Dan, Ben and Eric,
> The following two patches try to support a behavior seen with the Sierra Wireless EM7345, which wouldn't allow to reopen a port properly unless it was explicitly closed. The device ends up returning a "Close done" message for every "Open" request we send if the device is already open, so we try to detect that and run an explicit "Close" before the next "Open" attempt.
> The first patch is just refactoring where the open operation timeout logic is checked. The second patch is the actual hack for the EM7345.
> Eric, this patch comes from testing your ModemManager patch to detect the proxy crashes, as such an issue would leave the port open in the device side while we would assume it was closed.
> [PATCH 1/2] device: open timeout check in main state machine
> [PATCH 2/2] device: detect already open MBIM channel on EM7345
Both patches LGTM.
More information about the libmbim-devel