[PATCH 1/6] mbimcli,phonebook: add missing return statement in set_phonebook_delete_ready

[Aleksander Morgado]

On 27/07/17 03:44, Ben Chan wrote:
> When mbim_message_phonebook_delete_response_parse fails,
> set_phonebook_delete_ready should shutdown with a failure status and
> return.
> ---
>  src/mbimcli/mbimcli-phonebook.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Pushed to git master, mbim-1-14, mbim-1-12 and mbim-1-10.

> diff --git a/src/mbimcli/mbimcli-phonebook.c b/src/mbimcli/mbimcli-phonebook.c
> index 2fa46a6..fe3de2c 100644
> --- a/src/mbimcli/mbimcli-phonebook.c
> +++ b/src/mbimcli/mbimcli-phonebook.c
> @@ -238,7 +238,9 @@ set_phonebook_delete_ready (MbimDevice   *device,
>      if (!mbim_message_phonebook_delete_response_parse (response, &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
> +        return;
>      }
>  
>      g_print ("Phonebook entry/entries successfully deleted");
> 


-- 
Aleksander
https://aleksander.es