[PATCH 4/6] mbimcli,basic-connect: fix memory leaks

Aleksander Morgado aleksander at aleksander.es
Thu Jul 27 09:01:01 UTC 2017


On 27/07/17 03:44, Ben Chan wrote:
> ---
>  src/mbimcli/mbimcli-basic-connect.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Pushed to git master, mbim-1-14, mbim-1-12 and mbim-1-10.

> diff --git a/src/mbimcli/mbimcli-basic-connect.c b/src/mbimcli/mbimcli-basic-connect.c
> index 204ecb9..3ce0ce2 100644
> --- a/src/mbimcli/mbimcli-basic-connect.c
> +++ b/src/mbimcli/mbimcli-basic-connect.c
> @@ -350,6 +350,7 @@ query_device_caps_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -440,6 +441,7 @@ query_subscriber_ready_status_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -499,6 +501,7 @@ query_radio_state_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -545,6 +548,7 @@ query_device_services_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -637,6 +641,7 @@ pin_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -810,6 +815,7 @@ connect_ready (MbimDevice   *device,
>              &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1087,6 +1093,7 @@ home_provider_ready (MbimDevice   *device,
>                                                      &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1144,6 +1151,7 @@ preferred_providers_ready (MbimDevice   *device,
>                                                            &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1214,6 +1222,7 @@ visible_providers_ready (MbimDevice   *device,
>                                                          &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1300,6 +1309,7 @@ register_state_ready (MbimDevice   *device,
>                                                       &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1376,6 +1386,7 @@ signal_state_ready (MbimDevice   *device,
>                                                     &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1439,6 +1450,7 @@ packet_service_ready (MbimDevice   *device,
>                                                       &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> @@ -1514,6 +1526,7 @@ packet_statistics_ready (MbimDevice   *device,
>                                                          &error)) {
>          g_printerr ("error: couldn't parse response message: %s\n", error->message);
>          g_error_free (error);
> +        mbim_message_unref (response);
>          shutdown (FALSE);
>          return;
>      }
> 


-- 
Aleksander
https://aleksander.es


More information about the libmbim-devel mailing list