[PATCH 1/3] libmbim-glib: turn __mbim_utils_str_hex into public method

Aleksander Morgado aleksander at aleksander.es
Thu Jul 27 16:59:35 UTC 2017

>> > __mbim_utils_str_hex is a useful utility method for returning a
>> > hexadecimal string representation of a sequence of bytes in memory. This
>> > patch turns it a public method 'mbim_utils_str_hex' provided by
>> > libmbim-glib, which will be later used by mbimcli.
>> > ---
>> I don't think we should be doing that method public; it really is an internal method that we may or may not want keep with the same API in the future, nothing to do with MBIM...
>> How about, instead of adding it in our API, we create a common.la noinst library that includes this method, and we make libmbim-glib and mbimcli include that library? E.g. under src/common
> That sounds good to me. Do you prefer namings like:
>     src/common/mbim-common.{c,h}
>     mbim_common_str_hex

Yeah, that's fine I guess, yes.


More information about the libmbim-devel mailing list