review: dcbw/atds

[Ben Chan]

Dan, how about we name the commands like --atds-query-signal and
--atds-query-location, to be consistent with other query commands?

On Wed, Jun 28, 2017 at 7:18 AM, Dan Williams <dcbw at redhat.com> wrote:
> On Wed, 2017-06-28 at 10:08 +0200, Aleksander Morgado wrote:
>> On Tue, Jun 27, 2017 at 5:00 PM, Dan Williams <dcbw at redhat.com>
>> wrote:
>> > Branch review requested on dcbw/atds which attempts to implement
>> > the
>> > AT&T Device Services service, based on the Wireshark MBIM dissector
>> > r/e.
>> >
>> > It gets us at least LAC/TAC (which we could use to implement basic
>> > location) and extended Signal info.
>>
>> Nice branch! Tested it here with a Sierra MBIM modem and seems to be
>> working very well.
>>
>> It all looks good to me except for the typo in the commit message :)
>
> Merged to git master with a fixed up commit message.
>
> Dan
> _______________________________________________
> libmbim-devel mailing list
> libmbim-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libmbim-devel