[PATCH] Misplaced trace_transaction in transaction_complete_and_free

[Aleksander Morgado]

On 23/03/17 11:58, Carlo Lobrano wrote:
> Moved trace_transaction with error message in the right context.
> ---
> 
> Is this really a typo, or am I just missing something here?
> 

You're not missing anything :)

Pushed to git master

> ---
>  src/libmbim-glib/mbim-device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libmbim-glib/mbim-device.c b/src/libmbim-glib/mbim-device.c
> index 013fd8a..bc955ef 100644
> --- a/src/libmbim-glib/mbim-device.c
> +++ b/src/libmbim-glib/mbim-device.c
> @@ -219,12 +219,12 @@ transaction_complete_and_free (Transaction  *tr,
>          g_slice_free (TransactionWaitContext, tr->wait_ctx);
>  
>      if (error) {
> -        trace_transaction (tr, "complete: response");
> +        trace_transaction (tr, "complete: error");
>          g_simple_async_result_set_from_error (tr->result, error);
>          if (tr->fragments)
>              mbim_message_unref (tr->fragments);
>      } else {
> -        trace_transaction (tr, "complete: error");
> +        trace_transaction (tr, "complete: response");
>          g_assert (tr->fragments != NULL);
>          g_simple_async_result_set_op_res_gpointer (tr->result,
>                                                     tr->fragments,
> 


-- 
Aleksander
https://aleksander.es