Meson and Buildroot

[Yegor Yefremov]

Hola,

On Mon, Jul 26, 2021 at 11:33 AM Iñigo Martínez <inigomartinez at gmail.com> wrote:
>
> Hi,
>
> I wasn't aware that `bash-completion` also implied `bash` installation. It can be easily be made optional[0][1].
>
> I have provided a MR that handles this issue, taking also in account the change in `bash-completion` 2.10.
>
> Thank you for notifying the issue Yegor,

Now that libmbim is fixed, could you also post the same change for libqmi?

Thanks,

Regards,
Yegor


> [0] https://github.com/GNOME/dconf/blob/4057f8c84ff8c834dcd1cb82f946dd8cc49712ff/meson.build#L65
> [1] https://github.com/GNOME/tracker/blob/a07580610fe0d91124b2632f9a2ca1d5dfa8a40d/meson.build#L258
> [2] https://gitlab.freedesktop.org/mobile-broadband/libmbim/-/merge_requests/77
>
> El sáb, 24 jul 2021 a las 22:31, Yegor Yefremov (<yegorslists at googlemail.com>) escribió:
>>
>> Hey Aleksander, Iñigo,
>>
>> On Thu, Jul 22, 2021 at 9:44 AM Aleksander Morgado
>> <aleksander at aleksander.es> wrote:
>> >
>> > Hey Yegor,
>> >
>> > Adding Iñigo in CC, who is the one who did all this.
>> >
>> > > have you already tried to build libmbim via meson in BR?
>> > >
>> >
>> > Nope, no.
>> >
>> > > 1. libmbim needs bash_completion now. This means bash must be
>> > > installed as well. Does it make sense to make this feature optional?
>> > >
>> >
>> > I recall something about this, I think we had to add it in the CI
>> > image. Iñigo, is this something we can make optional?
>>
>> Should I submit a patch?
>>
>> > > 2. meson_post_install.py has a problem. In my case
>> > > "bash_completion_completionsdir" is an absolute path
>> > > "/usr/share/bash-completion/completions", hence os.path.join() ignores
>> > > prefix according to its definition. If you bump the minimal meson
>> > > version to 0.46, you can use install_data command with rename feature.
>> > >
>> >
>> > We default to 0.45.1 because that is the meson version released in a
>> > default Ubuntu 18.04 (LTS in support until April 2023). Unfortunately
>> > meson is pretty new, and the newest releases are very powerful, but
>> > until now we've always tried to be in line with what the LTS releases
>> > provide.
>>
>> OK. I see. As long as bash completion is optional, we can do without
>> this feature in BR.
>>
>> > > But I had no problems with gobject-introspection :-)
>> > >
>> >
>> > Hah :)
>> >
>> > Also, there is another blocker issue in the meson port right now,
>> > something related to how gtk-doc documentation is built. We cannot
>> > fully switch to meson until that is resolved. That would not be an
>> > issue for buildroot, though, no gtk-doc should be built there.
>>
>> Yup.
>>
>> Best regards,
>> Yegor
>
> _______________________________________________
> libmbim-devel mailing list
> libmbim-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libmbim-devel