[patch] compressed nef support

Rafael Espíndola rafael.espindola at gmail.com
Tue Jun 17 19:30:25 PDT 2008

> What's wrong with the current lossless jpeg?
Nothing, but if we can share the code that is better :-)

> A few comments. Class names: I planned on use less uppercase in class
> names. NEFFile would turn to NefFile, etc. It is even more visible with
> your NEFCFAIterator... I hadn't changed them all yet because it was low
> on my list, but on the other hand no creating new one.

> Member variable: they use the m_ prefix instead of the _ suffix. This is
> just a matter of taste, but for the sake of consistency, I'd prefer we
> stick to it.

> Also it does not survive to my testsuite:
> running test NEF-test D100 on
> file /home/hub/samples/nef/D100/dsc_0007.nef
> testsuite: ../../lib/neffile.cpp:180: const
> OpenRaw::Internals::NEFFile::NEFCompressionInfo
> OpenRaw::Internals::NEFFile::_getCompressionCurve(OpenRaw::RawData&):
> Assertion `curveEntry' failed.
> /bin/sh: line 4: 16125 Aborted                 (core dumped) ${dir}$tst
> FAIL: testsuite
> I can give you that file if you want :-) Hint: it is not compressed.

I think I have fixed it.

> Otherwise it looks good. Good work !

I think I am ready for a second pass :-)

> Hub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nef.patch
Type: application/octet-stream
Size: 21167 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/libopenraw-dev/attachments/20080617/05165748/attachment-0001.obj 

More information about the Libopenraw-dev mailing list