[PATCH v1] libqmi-glib, proxy: Change ownership of QMI devices to the configured user.

Aleksander Morgado aleksander at aleksander.es
Fri Dec 19 08:09:56 PST 2014


On Thu, Dec 18, 2014 at 6:32 PM, Dan Williams <dcbw at redhat.com> wrote:
> On Thu, 2014-12-18 at 17:19 +0100, Aleksander Morgado wrote:
>> On Tue, Dec 16, 2014 at 7:18 PM, Roshan Pius <rpius at chromium.org> wrote:
>> > Adding a udev rule to change ownership of all QMI devices to the
>> > configured user specified at compile time using --enable-qmi-username
>> > flag.
>> >
>>
>> Looks ok to me, does anyone have comments on this one?
>>
>> One of the things that I'm not sure we should consider is the case
>> where a distribution or a user doesn't want to make use of this logic.
>> Until now we just defaulted to checking the root user in the proxy;
>> but if no --enable-qmi-username is used during configure, we should
>> also fully skip installing the udev rule file. What do you think?
>
> Yeah, agreed.

Roshan, could you update the patch so that the udev rule file isn't
installed if --enable-qmi-username is not used?

-- 
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list