[PATCH 2/2] qmicli: add NAS Get Cell Location Info

[Bjørn Mork]

Aleksander Morgado <aleksander at aleksander.es> writes:
> On 09/05/14 10:46, Marius Kotsbak wrote:
>>> > Signed-off-by: Bjørn Mork <bjorn at mork.no>
>>> > ---
>>> >  src/qmicli/qmicli-nas.c | 424
>>> > ++++++++++++++++++++++++++++++++++++++++++++++++
>>> >  1 file changed, 424 insertions(+)
>>> >
>>> >
>> These patches (and the third in the  "Getting frequency band in use"
>> thread) works okay for me. Please apply them to master or a topic branch
>> until they are more complete.
>> 
>
> Pushed them to the 'bjorn/cell-location-info' branch for now. Still need
> to review them; but likely some new enum types need to be defined to
> handle the message contents.

Yup. Definitely.

And the cli output is plain wrong for RSSI etc.  Might be related to the
missing types, depending on how you want that implemented. In any case,
it also needs to be fixed before this can go to anything but a scratch
branch.

>> Would be nice to get this data translated in MM/NM to more user friendly
>> band names (is there an easy formula from channel number to band?)  that
>> can be used by the clients to display.
>
> Depending on how the enums are defined, we may get _get_string() or
> build_from_string() helper methods to print them.

Would be good.  Sounds like Marius is volunteering to work on this :-)



Bjørn