Updates to the QMI username logic

Aleksander Morgado aleksander at aleksander.es
Sun Nov 9 11:11:59 PST 2014


Hey Roshan,

Could you please review the following patches and tell me what you think?

[PATCH 1/2] build: rename '--enable-qmi-proxy-username'...
This one is just a rename of the configure option, so that it's more generic
(i.e. not related just to the proxy).


[PATCH 2/2] libqmi,utils: new internal __qmi_user_allowed() method
This one consolidates a new helper method to check if the user is allowed or
not. Please also note that your patch introduced a bug in qmi_proxy_open():
when the user wasn't allowed you would return FALSE without the GError being
set.

--
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list