SIM power patch

Aleksander Morgado aleksander at aleksander.es
Mon Feb 13 16:07:54 UTC 2017


Hey,

On Mon, Feb 13, 2017 at 4:37 PM, Kasper Holtze <kasper at holtze.dk> wrote:
> Den 16-12-2016 kl. 16:53 skrev Aleksander Morgado:
>>
>> On Fri, Dec 16, 2016 at 2:03 PM, Kasper Holtze <kasper at holtze.dk> wrote:
>>>
>>> I have updated the patch - it is attached to this mail.
>>
>> The patch doesn't apply ("git am 0001-...") on top of libqmi git
>> master; could you check why?
>>
> It applies to the current master now. There's two warnings regarding
> whitespaces _above_ the code I added, in the JSON file (it complains about
> trailing whitespaces, guess it has to do with the tabs in the lines
> above..).
>
> $ git apply --check 0001-Added-SIM-power-on-off-functionality.patch
>
> $ git am 0001-Added-SIM-power-on-off-functionality.patch
> Applying: Added-SIM-power-on-off-functionality
> .git/rebase-apply/patch:16: trailing whitespace.
>
> .git/rebase-apply/patch:32: trailing whitespace.
>
> warning: 2 lines add whitespace errors.

Could you add "since" : "1:18" tags to the new QMI messages and their TLVs? See:
https://cgit.freedesktop.org/libqmi/commit/?id=307de425d5390e6d8e5673a127035670eb73470f

-- 
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list