SIM power patch
aleksander at aleksander.es
Mon Feb 13 16:57:52 UTC 2017
On Mon, Feb 13, 2017 at 5:09 PM, Kasper Holtze <kasper at holtze.dk> wrote:
>>>> I have updated the patch - it is attached to this mail.
>>> The patch doesn't apply ("git am 0001-...") on top of libqmi git
>>> master; could you check why?
>> It applies to the current master now. There's two warnings regarding
>> whitespaces _above_ the code I added, in the JSON file (it complains about
>> trailing whitespaces, guess it has to do with the tabs in the lines
>> $ git apply --check 0001-Added-SIM-power-on-off-functionality.patch
>> $ git am 0001-Added-SIM-power-on-off-functionality.patch
>> Applying: Added-SIM-power-on-off-functionality
>> .git/rebase-apply/patch:16: trailing whitespace.
>> .git/rebase-apply/patch:32: trailing whitespace.
>> warning: 2 lines add whitespace errors.
> ...now with "since" tags...
The trailing whitespaces are actually new in your patch :) I fixed
those before pushing to git master.
I've also added the missing documentation links in a follow up commit.
And last, I've ended up separating the on/off operations into 2
different commands in qmicli... --uim-sim-power-off and
--uim-sim-power-on; basically so that we keep the same logic of one
qmicli operation per QMI message supported.
All in git master now.
More information about the libqmi-devel