[PATCH 1/2] Extended wda set format message to enable QMUX

[Aleksander Morgado]

Hey Carlo,

A couple more things.

On Thu, Feb 16, 2017 at 7:48 AM, Carlo Lobrano <c.lobrano at gmail.com> wrote:
> diff --git a/src/libqmi-glib/qmi-enums.h b/src/libqmi-glib/qmi-enums.h
> index 083370b..77ee5c3 100644
> --- a/src/libqmi-glib/qmi-enums.h
> +++ b/src/libqmi-glib/qmi-enums.h
> @@ -145,4 +145,17 @@ typedef enum {
>   * Since: 1.0
>   */
>
> +/**
> + * QmiDataEndpointType:
> + * @QMI_DATA_EP_TYPE_UNDEFINED: Data Endpoint Type undefined.
> + * @QMI_DATA_EP_TYPE_HSUSB: Data Endpoint Type HSUSB.
> + *
> + * Data Endpoint Type.
> + */
> +typedef enum {
> +    QMI_DATA_EP_TYPE_HSUSB     = 0X02,
> +    QMI_DATA_EP_TYPE_UNDEFINED = 0XFF,

QMI_DATA_ENDPOINT_TYPE_XXX (i.e. follow the same naming scheme used
for the actual enum type).

> +} QmiDataEndpointType;
> +

This new enum will generate a new get_string() method, could you also
add the Since: documentation to it? E.g.:

/**
 * qmi_data_endpoint_type_get_string:
 *
 * Since: 1.18.
 */

-- 
Aleksander
https://aleksander.es