WDS Bind Mux Port?

Bjørn Mork bjorn at mork.no
Tue Jan 17 15:12:07 UTC 2017


Daniele Palmas <dnlplm at gmail.com> writes:
> 2017-01-12 14:53 GMT+01:00 Bjørn Mork <bjorn at mork.no>:
>> Daniele Palmas <dnlplm at gmail.com> writes:
>>
>>> 2017-01-11 21:21 GMT+01:00 Bjørn Mork <bjorn at mork.no>:
>>>
>>> Thanks!! I'll try to take a look at this and, if possible, do some tests!
>>
>> I know I wasn't going to spend more time on this, but the attached
>> "Doh!" fix showed up in the back of my head while I was sleeping.  It
>> saves you from testing how many netdes your system can handle before it
>> slowly stops ;)
>>
>> Note that it still doesn't work. I'm doing something wrong when looking
>> up the interfaces. But the lookup code should probably be made much more
>> efficient than looping over a list anyway, since we'll do it for each
>> packet received.
>
> I'm slowly taking a look and I'm not an expert, so please forgive me
> if I say something silly.
>
> In qmimux_find_dev should netdev_for_each_lower_dev replaced by
> something like netdev_for_each_upper_dev_rcu ?
>
> Similar fix also in the other parts (e.g. add_mux_show).

Yes, that is probably correct.  I have a vertigo issue with network
device stacking ;)


Bjørn


More information about the libqmi-devel mailing list