[RFC] aleksander/dms-0x5556 branch

Aleksander Morgado aleksander at aleksander.es
Mon Jan 23 17:34:52 UTC 2017


On Mon, Jan 23, 2017 at 5:56 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
>> Sounds like a good plan to me.  I have always assumed that all these
>> 0x55.. requests were "vendor-specific", including the "FCC Auth"
>> request.
>>
>>> P.S.: the only thing I'm not much convinced of is the enumeration I
>>> prepared for the "DMS HP Change Device Mode" message, mainly because
>>> the items in the enumeration are just taken out of my tests with the
>>> HPlt4120. I just didn't want to have an API method (and qmicli
>>> command) expecting a "generic integer". Maybe we should just list in
>>> the enum the "fastboot" entry, which is the one used in HP firmware
>>> ugprade for sure?
>>
>> I think it's best to be careful here until we have more test-data.
>> These numbers could be static and have the same meaning across different
>> modems, like the Sierra Wireless UDUSBCOMP values.  But they could also
>> be dynamically allocated and therefore product, or even firmware
>> revision, specific.
>>
>> Better limit the enum to the well known "fastboot" entry for now.
>
> Yeah, I think that's safest as well. I'll add a new patch to remove
> the other entries.

Updated the branch now:
https://cgit.freedesktop.org/libqmi/commit/?h=aleksander/dms-0x5556&id=2b3ae965837f47a129d3b906fb6e833963bb9e92


-- 
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list