Support for LTE bands > 64

[Aleksander Morgado]

Hey!

>> > Most TLVs in the QMI protocol used a 64bit mask to flag the list of
>> > LTE bands, and therefore there was no way to reference bands greater
>> > than 64. These patches include support for additional TLVs that allow
>> > managing those bands.
>> >
>> > In particular, these patches include support for managing band 66 in
>> > QMI devices that support it, like the Telit LM940.
>> >
>> >   [PATCH 1/3] nas: define additional LTE bands
>> >   [PATCH 2/3] dms: new 'Extended LTE Band Capability' TLV in "Get
>> > Band...
>> >   [PATCH 3/3] nas: new 'Extended LTE Band Preference' TLV in
>> > "Set/Get...
>> >
>> > Comments?
>
>
> I tested the patch on a LM940 and looks good to me as well. Only two
> observation:
>

Thanks for testing!

> 1. LM940 with *nas-get-system-selection-preference* returns an unexpected
> pair of bands 252 and 255. Not sure if it is a modem error or some kind of
> valid information, do you have any idea?
>
> <<<<<< TLV:
> <<<<<<   type       = "Extended LTE Band Preference" (0x23)
> <<<<<<   length     = 32
> <<<<<<   value      =
> DF:18:09:3B:A0:01:00:00:02:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:48
> <<<<<<   translated = [ mask_low = '1787696847071' mask_mid_low = '2'
> mask_mid_high = '0' mask_high = '5188146770730811392' ]
>
> [/dev/cdc-wdm1] Successfully got system selection preference
>     Emergency mode: 'no'
>     Mode preference: 'umts'
>     Band preference: 'wcdma-2100, wcdma-pcs-1900, wcdma-1700-us,
> wcdma-850-us, wcdma-900'
>     LTE band preference: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 26, 28,
> 29, 30, 38, 40, 41'
>     LTE band preference (extended): '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20,
> 25, 26, 28, 29, 30, 38, 40, 41, 66, 252, 255'
>     TD-SCDMA band preference: 'a, b, c, d, e, f'
>     Roaming preference: 'any'
>     Network selection preference: 'automatic'
>     Service domain preference: 'cs-ps'
>     Service selection preference: 'automatic'
>
>
> 2. dms-get-bands-capability's ouput is hard to read
>
> [/dev/cdc-wdm1] Device band capabilities retrieved:
>     Bands: 'wcdma-2100, wcdma-pcs-1900, wcdma-dcs-1800, wcdma-1700-us,
> wcdma-850-us, wcdma-900'
>     LTE bands: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 38, 40, 41'
>     LTE bands (extended): '123457812131720252628293038404166'
>
> I updated the second patch to have a slighly better readability (patches are
> in attachment)
>
> [/dev/cdc-wdm1] Device band capabilities retrieved:
>     Bands: 'wcdma-2100, wcdma-pcs-1900, wcdma-dcs-1800, wcdma-1700-us,
> wcdma-850-us, wcdma-900'
>     LTE bands: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 38, 40, 41'
>     LTE bands (extended): '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 26, 28,
> 29, 30, 38, 40, 41, 66'
>

I used a slightly different code to achieve the same result, thanks
for reporting this and suggesting the fix ;)
https://cgit.freedesktop.org/libqmi/tree/src/qmicli/qmicli-dms.c#n2413

-- 
Aleksander
https://aleksander.es