[PATCH] dms: new 'Swi Get/Set USB Composition' messages

[Aleksander Morgado]

On Thu, Oct 19, 2017 at 5:21 PM, Bjørn Mork <bjorn at mork.no> wrote:
> Aleksander Morgado <aleksander at aleksander.es> writes:
>
>> +static const gchar *usb_composition_description[] = {
>> +    [QMI_DMS_SWI_USB_COMPOSITION_0]  = "HIP, DM, NMEA, AT, MDM1, MDM2, MDM3, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_1]  = "HIP, DM, NMEA, AT, MDM1, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_2]  = "HIP, DM, NMEA, AT, NIC1, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_3]  = "HIP, DM, NMEA, AT, MDM1, NIC1, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_4]  = "HIP, DM, NMEA, AT, NIC1, NIC2, NIC3, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_5]  = "HIP, DM, NMEA, AT, ECM1, MS",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_6]  = "DM, NMEA, AT, QMI",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_7]  = "DM, NMEA, AT, RMNET1, RMNET2, RMNET3",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_8]  = "DM, NMEA, AT, MBIM",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_9]  = "MBIM",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_10] = "NMEA, MBIM",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_11] = "DM, MBIM",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_12] = "DM, NMEA, MBIM",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_13] = "Dual configuration: USB composition 6 and USB composition 8",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_14] = "Dual configuration: USB composition 6 and USB composition 9",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_15] = "Dual configuration: USB composition 6 and USB composition 10",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_16] = "Dual configuration: USB composition 6 and USB composition 11",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_17] = "Dual configuration: USB composition 6 and USB composition 12",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_18] = "Dual configuration: USB composition 7 and USB composition 8",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_19] = "Dual configuration: USB composition 7 and USB composition 9",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_20] = "Dual configuration: USB composition 7 and USB composition 10",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_21] = "Dual configuration: USB composition 7 and USB composition 11",
>> +    [QMI_DMS_SWI_USB_COMPOSITION_22] = "Dual configuration: USB composition 7 and USB composition 12",
>> +};
>
>
> Thanks for doing this.  Just wanted to note that this table is a dump
> from the AT command CLI on one of my modems (I believe it was the
> MC7710) for some specific firmware version.  I have no information about
> the validity of that set of compositions for any other modem or
> firmware.
>

I assumed that the enumeration descriptions may not be completely ok
for all new firmware versions, which is part of why I decided to keep
it an enumeration but without using complex names. Anyway, I don't
think that would be a big deal, if we ever see any problem in the
future we can update the descriptions.

-- 
Aleksander
https://aleksander.es