Hey,
On Wed, Dec 12, 2018 at 3:12 AM Ben Chan <benchan at chromium.org> wrote:
>
> ---
> data/qmi-service-uim.json | 87 ++++++++++++++++++-
> .../libqmi-glib/libqmi-glib-docs.xml | 4 +
> 2 files changed, 90 insertions(+), 1 deletion(-)
>
> diff --git a/data/qmi-service-uim.json b/data/qmi-service-uim.json
> index 860acbe..96fcef1 100644
> --- a/data/qmi-service-uim.json
> +++ b/data/qmi-service-uim.json
> @@ -13,6 +13,10 @@
> { "name" : "QMI Message UIM",
> "type" : "Message-ID-Enum" },
>
> + // *********************************************************************************
> + { "name" : "QMI Indication UIM",
> + "type" : "Indication-ID-Enum" },
> +
> // *********************************************************************************
> { "common-ref" : "UIM Session",
> "name" : "Session",
> @@ -593,6 +597,87 @@
> "type" : "TLV",
> "since" : "1.18",
> "format" : "guint8" } ],
> - "output" : [ { "common-ref" : "Operation Result" } ] }
> + "output" : [ { "common-ref" : "Operation Result" } ] },
> +
> + // *********************************************************************************
> + { "name" : "Card Status",
> + "type" : "Indication",
> + "service" : "UIM",
> + "id" : "0x0032",
> + "version" : "1.0",
> + "since" : "1.22",
> + "output" : [ { "name" : "Card Status",
> + "id" : "0x10",
Is there any chance we can re-use this TLV type both in the indication
and in the response? Are they the same? E.g. a common TLV object added
at the beginning of the UIM service file.
> + "type" : "TLV",
> + "since" : "1.10",
That "since" seems off, should be 1.22.
> + "format" : "sequence",
> + "contents" : [ { "name" : "Index GW Primary",
> + "format" : "guint16" },
> + { "name" : "Index 1x Primary",
> + "format" : "guint16" },
> + { "name" : "Index GW Secondary",
> + "format" : "guint16" },
> + { "name" : "Index 1x Secondary",
> + "format" : "guint16" },
> + { "name" : "Cards",
> + "format" : "array",
> + "size-prefix-format" : "guint8",
> + "array-element" : { "name" : "Element",
> + "format" : "struct",
> + "contents" : [ { "name" : "Card State",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardState" },
> + { "name" : "UPIN State",
> + "format" : "guint8",
> + "public-format" : "QmiUimPinState" },
> + { "name" : "UPIN Retries",
> + "format" : "guint8" },
> + { "name" : "UPUK Retries",
> + "format" : "guint8" },
> + { "name" : "Error code",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardError" },
> + { "name" : "Applications",
> + "format" : "array",
> + "size-prefix-format" : "guint8",
> + "array-element" : { "name" : "Element",
> + "format" : "struct",
> + "contents" : [ { "name" : "Type",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardApplicationType" },
> + { "name" : "State",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardApplicationState" },
> + { "name" : "Personalization State",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardApplicationPersonalizationState" },
> + { "name" : "Personalization Feature",
> + "format" : "guint8",
> + "public-format" : "QmiUimCardApplicationPersonalizationFeature" },
> + { "name" : "Personalization Retries",
> + "format" : "guint8" },
> + { "name" : "Personalization Unblock Retries",
> + "format" : "guint8" },
> + { "name" : "Application Identifier Value",
> + "format" : "array",
> + "size-prefix-format" : "guint8",
> + "array-element" : { "format" : "guint8" } },
> + { "name" : "UPIN replaces PIN1",
> + "format" : "guint8",
> + "public-format" : "gboolean" },
> + { "name" : "PIN1 State",
> + "format" : "guint8",
> + "public-format" : "QmiUimPinState" },
> + { "name" : "PIN1 Retries",
> + "format" : "guint8" },
> + { "name" : "PUK1 Retries",
> + "format" : "guint8" },
> + { "name" : "PIN2 State",
> + "format" : "guint8",
> + "public-format" : "QmiUimPinState" },
> + { "name" : "PIN2 Retries",
> + "format" : "guint8" },
> + { "name" : "PUK2 Retries",
> + "format" : "guint8" } ] } } ] } } ] } ] }
>
> ]
> diff --git a/docs/reference/libqmi-glib/libqmi-glib-docs.xml b/docs/reference/libqmi-glib/libqmi-glib-docs.xml
> index 34bbb6f..373e744 100644
> --- a/docs/reference/libqmi-glib/libqmi-glib-docs.xml
> +++ b/docs/reference/libqmi-glib/libqmi-glib-docs.xml
> @@ -308,6 +308,10 @@
> <title>User Identity Module (UIM) service</title>
> <xi:include href="xml/qmi-client-uim.xml"/>
> <xi:include href="xml/qmi-enums-uim.xml"/>
> + <section>
> + <title>PDS Indications</title>
Should have said "UIM indications"
> + <xi:include href="xml/qmi-indication-uim-card-status.xml"/>
> + </section>
> <section>
> <title>UIM Requests</title>
> <xi:include href="xml/qmi-message-uim-reset.xml"/>
> --
> 2.20.0.405.gbc1bbc6f85-goog
>
--
Aleksander
https://aleksander.es