[PATCH v3 0/5] Add support for more LOC message types

[Aleksander Morgado]

On 22/02/18 23:43, Thomas Weißschuh wrote:
> This patchset adds support for more LOC messages types, so libqmi can be used
> to retrieve location information from it.
> It also adds some utility features that are needed for the functional part.
> (Patches one to three).
> 
> The message definitions deviate in small parts from the one in GOBI-API:
> In GNSS Sat Info messages the altitude source is guint8 instead of guint32, as
> observed in actual messages from the modem.
> The Sat Info itself is documented as being a struct, while in reality is an
> array of structs.
> 
> Changes in v2:
> 
> * Added big endian support for gfloat
> * Added documentation
> 
> Changes in v3:
> 
> * Custom endianess helpers use the libqmi specific prefixes
> * The code generator does not emit a unused error_out label
> * Correct "since" versions for new symbols
> * Correct "mandatory" attribute for TLVs
> * Remove the string "Indication" from the name of the NMEA indication
>   (This patch was part of the patchset for qmicli LOC support before)
> 

Except for the minor things in the last patch, it looks quite good to me. Leaving the last approval to Dan, as he's the one who has been playing with all this :)

> Thomas Weißschuh (5):
>   libqmi-glib: add __QMI_G{FLOAT,DOUBLE}_FROM_LE
>   libqmi-glib: handle gfloats on big-endian systems
>   qmi-codegen: add support for gdouble
>   qmi-codegen: allow empty input fields
>   loc: add definitions for more messages
> 
>  build-aux/qmi-codegen/Message.py                   |   4 +-
>  build-aux/qmi-codegen/VariableInteger.py           |   8 +-
>  build-aux/qmi-codegen/utils.py                     |   9 +-
>  data/qmi-common.json                               |  20 +-
>  data/qmi-service-loc.json                          | 338 +++++++++++++++++-
>  .../libqmi-glib/libqmi-glib-common.sections        |  75 ++++
>  docs/reference/libqmi-glib/libqmi-glib-docs.xml    |   8 +
>  src/libqmi-glib/Makefile.am                        |   4 +-
>  src/libqmi-glib/generated/Makefile.am              |   4 +-
>  src/libqmi-glib/libqmi-glib.h                      |   1 +
>  src/libqmi-glib/qmi-enums-loc.h                    | 376 +++++++++++++++++++++
>  src/libqmi-glib/qmi-flags64-loc.h                  | 103 ++++++
>  src/libqmi-glib/qmi-message.c                      |  33 +-
>  src/libqmi-glib/qmi-message.h                      |  28 ++
>  src/libqmi-glib/qmi-utils.h                        |  56 ++-
>  15 files changed, 1038 insertions(+), 29 deletions(-)
>  create mode 100644 src/libqmi-glib/qmi-flags64-loc.h
> 


-- 
Aleksander
https://aleksander.es