[PATCH v2] qmi-codegen: TLVs < 0x10 are mandatory by default

Thomas Weißschuh thomas at t-8ch.de
Sat Feb 24 15:26:51 UTC 2018


Deleting stuff always feels good :-)

On February 24, 2018 3:07:27 PM UTC, Aleksander Morgado <aleksander at aleksander.es> wrote:

>Wow, thanks for doing this cleanup :)
>On Sat, Feb 24, 2018 at 12:31 PM, Thomas Weißschuh <thomas at t-8ch.de>
>> The fallback logic of specifying an explicit value has been retained
>> because the following fields:
>> CTL Set Data Format: Protocol id=0x10 mandatory=True
>> NAS Attach Detach: Action id=0x10 mandatory=True
>> DMS Set Time: Time Reference Type id=0x10 mandatory=True
>> WDS Get Current Settings: Requested Settings id=0x10 mandatory=True
>> PDC Register: Enable Reporting id=0x10 mandatory=True
>> PDC List Configs: Config Type id=0x11 mandatory=True
>> PDC Delete Config: Id id=0x11 mandatory=True

>And now I wonder, shouldn't we fix those as well? They probably are
>optional anyway and we're making them mandatory.

We could. But at least one case has an explicit comment explainig that the default classification is wrong.
As I don't know if this is also the case for some of the other instances I opted for the safe logic.


More information about the libqmi-devel mailing list