[PATCH 0/4] Add support for more LOC message types
dcbw at redhat.com
Mon Jan 29 17:28:43 UTC 2018
On Sun, 2018-01-28 at 16:50 +0100, Thomas Weißschuh wrote:
> This patchset adds support for more LOC messages types, so libqmi can
> be used
> to retrieve location information from it.
> It also adds some utility features that are needed for the functional
> (Patches one to three).
Yay! The gdouble marshalling was the one thing I was trying to ignore
(eg not working on) while doing the LOC support in my branch; I also
don't have a BE machine I could test on. I'll try to carve out some
time to review this week, thanks!
> The message definitions deviate in small parts from the one in GOBI-
> In GNSS Sat Info messages the altitude source is guint8 instead of
> guint32, as
> observed in actual messages from the modem.
> The Sat Info itself is documented as being a struct, while in reality
> is an
> array of structs.
> The patchset is missing integration into qmicli and documentation
> strings for
> all the defined structs. I have a qmicli plugin that allows the
> querying of the
> location but it will need some cleanup before upstreaming.
> The documentation will follow after the patchset itself is in its
> final shape
> after review.
> Thomas Weißschuh (4):
> libqmi-glib: add GDOUBLE_FROM_LE
> qmi-codegen: add support for gdouble
> qmi-codegen: allow empty input fields
> loc: add definitions for more messages
> build-aux/qmi-codegen/Message.py | 2 +-
> build-aux/qmi-codegen/VariableInteger.py | 4 +-
> build-aux/qmi-codegen/utils.py | 9 +-
> data/qmi-common.json | 20 +-
> data/qmi-service-loc.json | 335
> .../libqmi-glib/libqmi-glib-common.sections | 19 ++
> src/libqmi-glib/Makefile.am | 4 +-
> src/libqmi-glib/generated/Makefile.am | 4 +-
> src/libqmi-glib/libqmi-glib.h | 1 +
> src/libqmi-glib/qmi-enums-loc.h | 121 +++++++-
> src/libqmi-glib/qmi-flags64-loc.h | 64 ++++
> src/libqmi-glib/qmi-message.c | 27 ++
> src/libqmi-glib/qmi-message.h | 26 ++
> src/libqmi-glib/qmi-utils.h | 73 +++++
> 14 files changed, 689 insertions(+), 20 deletions(-)
> create mode 100644 src/libqmi-glib/qmi-flags64-loc.h
More information about the libqmi-devel